linux-kernel - Re: [PATCH] ASoC: cs48l32: Use modern PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <29fa2bff-1e07-4c07-8902-26193d506ca1@opensource.cirrus.com>
Date: Sat, 19 Apr 2025 10:58:48 +0100
From: Richard Fitzgerald <rf@...nsource.cirrus.com>
To: Nathan Chancellor <nathan@...nel.org>,
        David Rhodes <david.rhodes@...rus.com>,
        Mark Brown <broonie@...nel.org>
Cc: Stuart Henderson <stuarth@...nsource.cirrus.com>,
        Qi Zhou <qi.zhou@...rus.com>,
        Piotr Stankiewicz <piotrs@...nsource.cirrus.com>,
        linux-sound@...r.kernel.org, patches@...nsource.cirrus.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: cs48l32: Use modern PM_OPS

On 18/4/25 21:36, Nathan Chancellor wrote:
> When building for a platform that does not support CONFIG_PM, such as
> s390, cs48l32_runtime_{suspend,resume}() are unused because
> SET_RUNTIME_PM_OPS does not reference its argument when CONFIG_PM is not
> set:
> 
>    sound/soc/codecs/cs48l32.c:3822:12: error: 'cs48l32_runtime_suspend' defined but not used [-Werror=unused-function]
>     3822 | static int cs48l32_runtime_suspend(struct device *dev)
>          |            ^~~~~~~~~~~~~~~~~~~~~~~
>    sound/soc/codecs/cs48l32.c:3779:12: error: 'cs48l32_runtime_resume' defined but not used [-Werror=unused-function]
>     3779 | static int cs48l32_runtime_resume(struct device *dev)
>          |            ^~~~~~~~~~~~~~~~~~~~~~
>    cc1: all warnings being treated as errors
> 
> Use RUNTIME_PM_OPS and pm_ptr() to ensure these functions are seen as
> used by the compiler but be dropped in the final object file when
> CONFIG_PM is not set, matching the current behavior while clearing up
> the warnings.
> 
> Fixes: e2bcbf99d045 ("ASoC: cs48l32: Add driver for Cirrus Logic CS48L32 audio DSP")
> Signed-off-by: Nathan Chancellor <nathan@...nel.org>
> ---
>   sound/soc/codecs/cs48l32.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/soc/codecs/cs48l32.c b/sound/soc/codecs/cs48l32.c
> index 8fd0df671730..90a795230d27 100644
> --- a/sound/soc/codecs/cs48l32.c
> +++ b/sound/soc/codecs/cs48l32.c
> @@ -3834,7 +3834,7 @@ static int cs48l32_runtime_suspend(struct device *dev)
>   }
>   
>   static const struct dev_pm_ops cs48l32_pm_ops = {
> -	SET_RUNTIME_PM_OPS(cs48l32_runtime_suspend, cs48l32_runtime_resume, NULL)
> +	RUNTIME_PM_OPS(cs48l32_runtime_suspend, cs48l32_runtime_resume, NULL)
>   };
>   
>   static int cs48l32_configure_clk32k(struct cs48l32 *cs48l32)
> @@ -4057,7 +4057,7 @@ MODULE_DEVICE_TABLE(spi, cs48l32_spi_ids);
>   static struct spi_driver cs48l32_spi_driver = {
>   	.driver = {
>   		.name		= "cs48l32",
> -		.pm		= &cs48l32_pm_ops,
> +		.pm		= pm_ptr(&cs48l32_pm_ops),
>   		.of_match_table	= cs48l32_of_match,
>   	},
>   	.probe		= &cs48l32_spi_probe,
> 
> ---
> base-commit: 0b0a18f1bd72c64ae845a32d975f6d4c727b38e3
> change-id: 20250418-cs48l32-modern-pm_ops-3e4b5860e366
> 
> Best regards,

Thanks.
Reviewed-by: Richard Fitzgerald <rf@...nsource.cirrus.com>