linux-kernel - Re: [PATCH v6 1/2] staging: rtl8723bs: Remove duplicate NULL tests on pstat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aAPOFccMEWDHjJ_S@smile.fi.intel.com>
Date: Sat, 19 Apr 2025 19:23:49 +0300
From: Andy Shevchenko <andy@...nel.org>
To: Abraham Samuel Adekunle <abrahamadekunle50@...il.com>
Cc: julia.lawall@...ia.fr, gregkh@...uxfoundation.org,
	linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev,
	dan.carpenter@...aro.org
Subject: Re: [PATCH v6 1/2] staging: rtl8723bs: Remove duplicate NULL tests
 on pstat

On Fri, Apr 18, 2025 at 03:41:56PM +0000, Abraham Samuel Adekunle wrote:
> The pstat pointer has been previously tested for NULL after being
> initialized as seen from line 970-973 of the file.
> The first NULL test is shown below:

> 		pstat = rtw_get_stainfo(pstapriv, GetAddr2Ptr(pframe));
> 		 if (!pstat) {
> 			 status = WLAN_REASON_CLASS2_FRAME_FROM_NONAUTH_STA;
> 			goto asoc_class2_error;
> 		}

It's too much for such a change. You can do that in the comment area
(after '---' line below), or drop it completely. You can rephrase that
the pointer is checked before the changed lines.

> Remove the second NULL test to avoid redundancy in code.
> 
> Found by Coccinelle

Missing period.

-- 
With Best Regards,
Andy Shevchenko