linux-kernel - Re: [PATCH v6 2/2] staging: rtl8723bs: Prevent duplicate NULL tests on psta pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aAPOYhdJoD23b4np@smile.fi.intel.com>
Date: Sat, 19 Apr 2025 19:25:06 +0300
From: Andy Shevchenko <andy@...nel.org>
To: Abraham Samuel Adekunle <abrahamadekunle50@...il.com>
Cc: julia.lawall@...ia.fr, gregkh@...uxfoundation.org,
	linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev,
	dan.carpenter@...aro.org
Subject: Re: [PATCH v6 2/2] staging: rtl8723bs: Prevent duplicate NULL tests
 on psta pointer

On Fri, Apr 18, 2025 at 03:41:57PM +0000, Abraham Samuel Adekunle wrote:
> The psta pointer had previously been tested for NULL after initialization,
> as seen in the code below:
> 
> 		psta = rtw_get_stainfo(&padapter->stapriv, pattrib->ra);
> 		...
>                 if (!psta)
> 			return _FAIL;
> This makes a second NULL test on psta unnecessary.
> 
> Remove the second NULL test on psta to avoid redundancy in code.
> 
> Found by Cocinelle

Missing period.

P.S. Here the commit message is fine, however misindented
(check the indentation).

-- 
With Best Regards,
Andy Shevchenko