linux-kernel - Re: [PATCH] iio: frequency: Use SLEEP bit instead of RESET to disable output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKUZ0zLMAZFHwvuqfoL6JZfphYRhtjkqOyi50_ZffbA7-4MCew@mail.gmail.com>
Date: Sat, 19 Apr 2025 21:41:50 -0400
From: Gabriel Shahrouzi <gshahrouzi@...il.com>
To: Marcelo Schmitt <marcelo.schmitt1@...il.com>
Cc: gregkh@...uxfoundation.org, jic23@...nel.org, lars@...afoo.de, 
	linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-staging@...ts.linux.dev, Michael.Hennerich@...log.com, 
	skhan@...uxfoundation.org, linux-kernel-mentees@...ts.linux.dev, 
	stable@...r.kernel.org
Subject: Re: [PATCH] iio: frequency: Use SLEEP bit instead of RESET to disable output

On Sat, Apr 19, 2025 at 5:45 PM Marcelo Schmitt
<marcelo.schmitt1@...il.com> wrote:
>
> On 04/17, Gabriel Shahrouzi wrote:
> > According to the AD9832 datasheet (Table 10, D12 description), setting
> > the RESET bit forces the phase accumulator to zero, which corresponds to
> > a full-scale DC output, rather than disabling the output signal.
> >
> > The correct way to disable the output and enter a low-power state is to
> > set the AD9832_SLEEP bit (Table 10, D13 description), which powers down
> > the internal DAC current sources and disables internal clocks.
> >
> > Fixes: ea707584bac1 ("Staging: IIO: DDS: AD9832 / AD9835 driver")
> > Cc: stable@...r.kernel.org
> > Signed-off-by: Gabriel Shahrouzi <gshahrouzi@...il.com>
> > ---
> Looks okay.
>
> Reviewed-by: Marcelo Schmitt <marcelo.schmitt1@...il.com>
>
> Unrelated to this patch but, if anybody be looking to work on getting this out
> of staging, I think maybe this driver could use out_altvoltage_powerdown ABI
> instead of this custom out_altvoltageX_out_enable.
> Crazy thing this driver doesn't declare a single IIO channel.
> Seems to be somewhat ancient IIO driver.
I can start tackling this.
>
> Regards,
> Marcelo