linux-kernel - Re: [PATCH] iio: frequency: Use SLEEP bit instead of RESET to disable output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250421120749.66b04533@jic23-huawei>
Date: Mon, 21 Apr 2025 12:07:49 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Gabriel Shahrouzi <gshahrouzi@...il.com>
Cc: Marcelo Schmitt <marcelo.schmitt1@...il.com>,
 gregkh@...uxfoundation.org, lars@...afoo.de, linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev,
 Michael.Hennerich@...log.com, skhan@...uxfoundation.org,
 linux-kernel-mentees@...ts.linux.dev, stable@...r.kernel.org
Subject: Re: [PATCH] iio: frequency: Use SLEEP bit instead of RESET to
 disable output

On Sat, 19 Apr 2025 21:41:50 -0400
Gabriel Shahrouzi <gshahrouzi@...il.com> wrote:

> On Sat, Apr 19, 2025 at 5:45 PM Marcelo Schmitt
> <marcelo.schmitt1@...il.com> wrote:
> >
> > On 04/17, Gabriel Shahrouzi wrote:  
> > > According to the AD9832 datasheet (Table 10, D12 description), setting
> > > the RESET bit forces the phase accumulator to zero, which corresponds to
> > > a full-scale DC output, rather than disabling the output signal.
> > >
> > > The correct way to disable the output and enter a low-power state is to
> > > set the AD9832_SLEEP bit (Table 10, D13 description), which powers down
> > > the internal DAC current sources and disables internal clocks.
> > >
> > > Fixes: ea707584bac1 ("Staging: IIO: DDS: AD9832 / AD9835 driver")
> > > Cc: stable@...r.kernel.org
> > > Signed-off-by: Gabriel Shahrouzi <gshahrouzi@...il.com>
> > > ---  
> > Looks okay.
> >
> > Reviewed-by: Marcelo Schmitt <marcelo.schmitt1@...il.com>
> >
> > Unrelated to this patch but, if anybody be looking to work on getting this out
> > of staging, I think maybe this driver could use out_altvoltage_powerdown ABI
> > instead of this custom out_altvoltageX_out_enable.
> > Crazy thing this driver doesn't declare a single IIO channel.
> > Seems to be somewhat ancient IIO driver.  
> I can start tackling this.
This has crossed with a series from Siddarth.

Take a look at what is in:
https://web.git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/commit/?h=testing&id=aa703203cbbca22ac46d42d4cd41232491827152

Please rebase this one on top of that as I think the bug is still there?

Given there is work going on for this driver and the bugs are ancient, I'll
not take any patches through the fixes tree for now. Instead I'll just queue
them up for the next merge window.

Thanks,

Jonathan

> >
> > Regards,
> > Marcelo  
>