linux-kernel - Re: [PATCH] lib/crypto: blake2s: Disable self test if CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250420195657.GA291714@sol.localdomain>
Date: Sun, 20 Apr 2025 12:56:57 -0700
From: Eric Biggers <ebiggers@...nel.org>
To: Daniel Palmer <daniel@...f.com>
Cc: herbert@...dor.apana.org.au, davem@...emloft.net, Jason@...c4.com,
	linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
	Daniel Palmer <daniel@...ngy.jp>
Subject: Re: [PATCH] lib/crypto: blake2s: Disable self test if CONFIG_CRYPTO
 isn't enabled

On Fri, Apr 18, 2025 at 07:59:45AM -0700, Eric Biggers wrote:
> On Fri, Apr 18, 2025 at 09:02:16PM +0900, Daniel Palmer wrote:
> > From: Daniel Palmer <daniel@...ngy.jp>
> > 
> > Currently CONFIG_CRYPTO_MANAGER_DISABLE_TESTS is used to remove
> > the self test code. CONFIG_CRYPTO_MANAGER_DISABLE_TESTS depends on
> > CONFIG_CRYPTO so its impossible to disable the self test without
> > enabling CONFIG_CRYPTO.
> > 
> > If you don't want CONFIG_CRYPTO you probably don't want self tests
> > so remove the self tests in that case too.
> > 
> > Fixes: 66d7fb94e4ff ("crypto: blake2s - generic C library implementation and selftest")
> > 
> > Signed-off-by: Daniel Palmer <daniel@...ngy.jp>
> > ---
> >  lib/crypto/blake2s.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> Acked-by: Eric Biggers <ebiggers@...nel.org>
> 
> This is okay as a quick fix, but really the lib/crypto/ tests should be
> refactored into KUnit tests that aren't dependent on CRYPTO.  FWIW, I recently
> fixed this for the CRC functions: lib/tests/crc_kunit.c.
> 

My series "[PATCH 0/9] Clean up the crypto testing options"
(https://lore.kernel.org/r/20250419161543.139344-1-ebiggers@kernel.org/) also
fixes this by replacing CRYPTO_MANAGER_DISABLE_TESTS with a non-negated option.
(But we should still disentangle the library tests from CRYPTO at some point.)

- Eric