linux-kernel - Re: [PATCH v8 01/24] PCI/P2PDMA: Refactor the p2pdma mapping helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4698ae08-4350-427c-a024-401610b42e5e@oracle.com>
Date: Mon, 21 Apr 2025 01:35:26 +0530
From: ALOK TIWARI <alok.a.tiwari@...cle.com>
To: Leon Romanovsky <leon@...nel.org>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Jens Axboe <axboe@...nel.dk>, Christoph Hellwig <hch@....de>,
        Keith Busch <kbusch@...nel.org>
Cc: Jake Edge <jake@....net>, Jonathan Corbet <corbet@....net>,
        Jason Gunthorpe <jgg@...pe.ca>, Zhu Yanjun <zyjzyj2000@...il.com>,
        Robin Murphy <robin.murphy@....com>, Joerg Roedel <joro@...tes.org>,
        Will Deacon <will@...nel.org>, Sagi Grimberg <sagi@...mberg.me>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Logan Gunthorpe <logang@...tatee.com>,
        Yishai Hadas <yishaih@...dia.com>,
        Shameer Kolothum <shameerali.kolothum.thodi@...wei.com>,
        Kevin Tian <kevin.tian@...el.com>,
        Alex Williamson <alex.williamson@...hat.com>,
        Jérôme Glisse <jglisse@...hat.com>,
        Andrew Morton <akpm@...ux-foundation.org>, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-block@...r.kernel.org,
        linux-rdma@...r.kernel.org, iommu@...ts.linux.dev,
        linux-nvme@...ts.infradead.org, linux-pci@...r.kernel.org,
        kvm@...r.kernel.org, linux-mm@...ck.org,
        Niklas Schnelle <schnelle@...ux.ibm.com>,
        Chuck Lever <chuck.lever@...cle.com>,
        Luis Chamberlain <mcgrof@...nel.org>,
        Matthew Wilcox <willy@...radead.org>,
        Dan Williams
 <dan.j.williams@...el.com>,
        Kanchan Joshi <joshi.k@...sung.com>,
        Chaitanya Kulkarni <kch@...dia.com>,
        Leon Romanovsky <leonro@...dia.com>
Subject: Re: [PATCH v8 01/24] PCI/P2PDMA: Refactor the p2pdma mapping helpers



Since we're touching this code, it might be a good opportunity to fix 
the old typo

On 18-04-2025 12:17, Leon Romanovsky wrote:
> +/**
> + * pci_p2pdma_bus_addr_map - map a PCI_P2PDMA_MAP_BUS_ADDR P2P transfer
> + * @state:	P2P state structure
> + * @paddr:	physical address to map
> + *
> + * Map a physically contigous PCI_P2PDMA_MAP_BUS_ADDR transfer.

old typo contigous -> contiguous

> + */
> +static inline dma_addr_t
> +pci_p2pdma_bus_addr_map(struct pci_p2pdma_map_state *state, phys_addr_t paddr)
>   {
> -	return PCI_P2PDMA_MAP_NOT_SUPPORTED;
> +	WARN_ON_ONCE(state->map != PCI_P2PDMA_MAP_BUS_ADDR);
> +	return paddr + state->bus_off;
>   }
> -#endif /* CONFIG_PCI_P2PDMA */


Thanks,
Alok