linux-kernel - Re: [PATCH v4 05/13] media: nxp: imx8-isi: Remove redundant check for dma_set_mask_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250421211927.GO17813@pendragon.ideasonboard.com>
Date: Tue, 22 Apr 2025 00:19:27 +0300
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: Frank Li <Frank.Li@....com>
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>,
	Rui Miguel Silva <rmfrfs@...il.com>,
	Martin Kepplinger <martink@...teo.de>,
	Purism Kernel Team <kernel@...i.sm>, linux-media@...r.kernel.org,
	devicetree@...r.kernel.org, imx@...ts.linux.dev,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Robert Chiras <robert.chiras@....com>,
	"Guoniu.zhou" <guoniu.zhou@....com>
Subject: Re: [PATCH v4 05/13] media: nxp: imx8-isi: Remove redundant check
 for dma_set_mask_and_coherent()

Hi Frank,

Thank you for the patch.

On Tue, Apr 08, 2025 at 05:53:03PM -0400, Frank Li wrote:
> dma_set_mask_and_coherent() never return failure when mask bigger than
> 32bit.
> 
> See commit f7ae20f2fc4e ("docs: dma: correct dma_set_mask() sample code")
> 
> So remove return value check for dma_set_mask_and_coherent().
> 
> Signed-off-by: Frank Li <Frank.Li@....com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

> ---
>  drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c
> index 015350c6f2784..073ea5912de3b 100644
> --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c
> +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c
> @@ -444,11 +444,7 @@ static int mxc_isi_probe(struct platform_device *pdev)
>  	}
>  
>  	dma_size = isi->pdata->has_36bit_dma ? 36 : 32;
> -	ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(dma_size));
> -	if (ret) {
> -		dev_err(dev, "failed to set DMA mask\n");
> -		return ret;
> -	}
> +	dma_set_mask_and_coherent(dev, DMA_BIT_MASK(dma_size));
>  
>  	pm_runtime_enable(dev);
>  

-- 
Regards,

Laurent Pinchart