linux-kernel - Re: [PATCH v4 06/13] media: nxp: imx8-isi: Use dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250421212109.GP17813@pendragon.ideasonboard.com>
Date: Tue, 22 Apr 2025 00:21:09 +0300
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: Frank Li <Frank.Li@....com>
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>,
	Rui Miguel Silva <rmfrfs@...il.com>,
	Martin Kepplinger <martink@...teo.de>,
	Purism Kernel Team <kernel@...i.sm>, linux-media@...r.kernel.org,
	devicetree@...r.kernel.org, imx@...ts.linux.dev,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Robert Chiras <robert.chiras@....com>,
	"Guoniu.zhou" <guoniu.zhou@....com>
Subject: Re: [PATCH v4 06/13] media: nxp: imx8-isi: Use dev_err_probe()
 simplify code

Hi Frank,

Thank you for the patch.

On Tue, Apr 08, 2025 at 05:53:04PM -0400, Frank Li wrote:
> Use dev_err_probe() simplify code. No functional changes intended.

In the subject line and here, s/simplify/to simplify/

> Signed-off-by: Frank Li <Frank.Li@....com>
> ---
>  drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c | 13 ++++---------
>  1 file changed, 4 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c
> index 073ea5912de3b..398cc03443be3 100644
> --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c
> +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c
> @@ -428,19 +428,14 @@ static int mxc_isi_probe(struct platform_device *pdev)
>  		return dev_err_probe(dev, isi->num_clks, "Failed to get clocks\n");
>  
>  	isi->regs = devm_platform_ioremap_resource(pdev, 0);
> -	if (IS_ERR(isi->regs)) {
> -		dev_err(dev, "Failed to get ISI register map\n");
> -		return PTR_ERR(isi->regs);
> -	}
> +	if (IS_ERR(isi->regs))
> +		return dev_err_probe(dev, PTR_ERR(isi->regs), "Failed to get ISI register map\n");

		return dev_err_probe(dev, PTR_ERR(isi->regs),
				     "Failed to get ISI register map\n");

>  
>  	if (isi->pdata->gasket_ops) {
>  		isi->gasket = syscon_regmap_lookup_by_phandle(dev->of_node,
>  							      "fsl,blk-ctrl");
> -		if (IS_ERR(isi->gasket)) {
> -			ret = PTR_ERR(isi->gasket);
> -			dev_err(dev, "failed to get gasket: %d\n", ret);
> -			return ret;
> -		}
> +		if (IS_ERR(isi->gasket))
> +			return dev_err_probe(dev, PTR_ERR(isi->gasket), "failed to get gasket\n");

			return dev_err_probe(dev, PTR_ERR(isi->gasket),
					     "failed to get gasket\n");

With that,

Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

>  	}
>  
>  	dma_size = isi->pdata->has_36bit_dma ? 36 : 32;

-- 
Regards,

Laurent Pinchart