linux-kernel - Re: [PATCHv2 net] bonding: use permanent address for MAC swapping if device address is same

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aAXhiW6n-ftxAr9M@fedora>
Date: Mon, 21 Apr 2025 06:11:21 +0000
From: Hangbin Liu <liuhangbin@...il.com>
To: Jay Vosburgh <jv@...sburgh.net>
Cc: netdev@...r.kernel.org, Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Nikolay Aleksandrov <razor@...ckwall.org>,
	Simon Horman <horms@...nel.org>, Cosmin Ratiu <cratiu@...dia.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCHv2 net] bonding: use permanent address for MAC swapping if
 device address is same

On Sun, Apr 20, 2025 at 10:10:24PM -0700, Jay Vosburgh wrote:
> >I'm not familiar with infiniband devices. Can we use eth_random_addr()
> >to set random addr for infiniband devices? And what about other device
> >type? Just return error directly?
> 
> 	Infiniband devices have fixed MAC addresses that cannot be
> changed.  Bonding permits IB devices only in active-backup mode, and
> will set fail_over_mac to active (fail_over_mac=follow is not permitted
> for IB).
> 
> 	I don't understand your questions about other device types or
> errors, could you elaborate?
> 

I mean what if other device type enslaves, other than ethernet or infiniband.
I'm not sure if we can set random mac address for these devices. Should we
ignore all none ethernet device or devices that don't support
ndo_set_mac_address?

Thanks
Hangbin