linux-kernel - Re: [PATCH v2 net-next 1/3] ionic: extend the QSFP module sprom for more pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250421105410.GA2789685@horms.kernel.org>
Date: Mon, 21 Apr 2025 11:54:10 +0100
From: Simon Horman <horms@...nel.org>
To: Shannon Nelson <shannon.nelson@....com>
Cc: andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, brett.creeley@....com
Subject: Re: [PATCH v2 net-next 1/3] ionic: extend the QSFP module sprom for
 more pages

On Tue, Apr 15, 2025 at 04:13:14PM -0700, Shannon Nelson wrote:
> Some QSFP modules have more eeprom to be read by ethtool than
> the initial high and low page 0 that is currently available
> in the DSC's ionic sprom[] buffer.  Since the current sprom[]
> is baked into the middle of an existing API struct, to make
> the high end of page 1 and page 2 available a block is carved
> from a reserved space of the existing port_info struct and the
> ionic_get_module_eeprom() service is taught how to get there.
> 
> Newer firmware writes the additional QSFP page info here,
> yet this remains backward compatible because older firmware
> sets this space to all 0 and older ionic drivers do not use
> the reserved space.
> 
> Reviewed-by: Brett Creeley <brett.creeley@....com>
> Signed-off-by: Shannon Nelson <shannon.nelson@....com>

Reviewed-by: Simon Horman <horms@...nel.org>