linux-kernel - Re: [PATCH] iio: accel: adis16201: Use IIO_VAL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKUZ0zKgvwhzgq8+_HG845QDze2SGN2fPwdXuN=UkATea6Nuag@mail.gmail.com>
Date: Mon, 21 Apr 2025 08:33:00 -0400
From: Gabriel Shahrouzi <gshahrouzi@...il.com>
To: jic23@...nel.org, lars@...afoo.de, linux-iio@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Michael.Hennerich@...log.com, 
	Greg KH <gregkh@...uxfoundation.org>
Cc: skhan@...uxfoundation.org, linux-kernel-mentees@...ts.linux.dev, 
	stable@...r.kernel.org
Subject: Re: [PATCH] iio: accel: adis16201: Use IIO_VAL_INT for temperature scale

Not sure this is worth mentioning but one of the emails from using
get_maintainer.pl on the patch listed a deprecated email:
gregkh@...e.de.

On Mon, Apr 21, 2025 at 8:28 AM Gabriel Shahrouzi <gshahrouzi@...il.com> wrote:
>
> This is a leftover from the patch: commit cf96ffd8c2ed
> ("staging:iio:accel:adis16201 move to chan_spec based setup.").
> Initially *val = 0 and *val2 = -470000.  However, they were later
> changed to -470 and 0 respectively but their return type was not
> updated.
>
> Use correct type as -470 is an integer in the base units.
>
> Fixes: cf96ffd8c2ed ("staging:iio:accel:adis16201 move to chan_spec based setup.")
> Cc: stable@...r.kernel.org
> Signed-off-by: Gabriel Shahrouzi <gshahrouzi@...il.com>
> ---
>  drivers/iio/accel/adis16201.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/accel/adis16201.c b/drivers/iio/accel/adis16201.c
> index dcc8d9f2ee0f1..1f27386edcc4e 100644
> --- a/drivers/iio/accel/adis16201.c
> +++ b/drivers/iio/accel/adis16201.c
> @@ -125,7 +125,7 @@ static int adis16201_read_raw(struct iio_dev *indio_dev,
>                 case IIO_TEMP:
>                         *val = -470;
>                         *val2 = 0;
> -                       return IIO_VAL_INT_PLUS_MICRO;
> +                       return IIO_VAL_INT;
>                 case IIO_ACCEL:
>                         /*
>                          * IIO base unit for sensitivity of accelerometer
> --
> 2.43.0
>