linux-kernel - Re: [PATCH] ASoC: wm8998: Add Kconfig prompt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aAZS8XVHtw5zxD2d@opensource.cirrus.com>
Date: Mon, 21 Apr 2025 15:15:13 +0100
From: Charles Keepax <ckeepax@...nsource.cirrus.com>
To: git@...tzsch.eu
Cc: Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
        ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org,
        linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: wm8998: Add Kconfig prompt

On Fri, Apr 18, 2025 at 10:22:04PM +0200, André Apitzsch via B4 Relay wrote:
> From: André Apitzsch <git@...tzsch.eu>
> 
> Add tristate prompt to allow codec selection.
> 
> Signed-off-by: André Apitzsch <git@...tzsch.eu>
> ---

Generally its good to say why one wants to make the symbol
selectable, usually its to use it with simple card, although at
least historically I think simple card struggled to handle the
required set_sysclk calls for these codecs.

But I have no objection to this being exported:

Reviewed-by: Charles Keepax <ckeepax@...nsource.cirrus.com>

Thanks,
Charles
>  sound/soc/codecs/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
> index 40bb7a1d44bcfa4c386f2eba0f475efeeedf1bdb..9ecc4bb7f75ff9fce87970d2e46ace72444e55b4 100644
> --- a/sound/soc/codecs/Kconfig
> +++ b/sound/soc/codecs/Kconfig
> @@ -2479,7 +2479,7 @@ config SND_SOC_WM8997
>  	depends on MFD_WM8997 && MFD_ARIZONA
>  
>  config SND_SOC_WM8998
> -	tristate
> +	tristate "Wolfson Microelectronics WM8998 codec driver"
>  	depends on MFD_WM8998 && MFD_ARIZONA
>  
>  config SND_SOC_WM9081
> 
> ---
> base-commit: 7e74f756f5f643148ca5537bf2fee6767e4b0ed9
> change-id: 20250418-wm8998-defae73b3320
> 
> Best regards,
> -- 
> André Apitzsch <git@...tzsch.eu>
> 
> 
>