linux-kernel - Re: [PATCH] RISC-V: Kconfig: Fix help text of CMDLINE_EXTEND

Open Source and information security mailing list archives

Message-ID: <9d4b7987-40e9-4bed-8869-a514e6c96697@ghiti.fr>
Date: Tue, 22 Apr 2025 15:01:48 +0200
From: Alexandre Ghiti <alex@...ti.fr>
To: Yeking@...54.com
Cc: aou@...s.berkeley.edu, dmaliotaki@...il.com,
 linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org,
 mick@....forth.gr, palmer@...belt.com, paul.walmsley@...ive.com
Subject: Re: [PATCH] RISC-V: Kconfig: Fix help text of CMDLINE_EXTEND

Hi,

On 21/04/2025 12:16, Yeking@...54.com wrote:
> LoongArch (merged):
> https://lore.kernel.org/all/tencent_7FAF68BF7A2EAD9BFE869ECFDB837F980309@qq.com/
>
> RISC-V:
> https://lore.kernel.org/all/tencent_A93C7FB46BFD20054AD2FEF4645913FF550A@qq.com/
>
> PowerPC:
> https://lore.kernel.org/all/tencent_6E57A00F6D56CF8475CF9FD13370FBC1CF06@qq.com/
>
> SH:
> https://lore.kernel.org/all/tencent_40B6A6E7C79AEEEFEC79A07DE00724909A05@qq.com/
>
> ARM (rejected):
> https://lore.kernel.org/all/tencent_3E8155B4A33D48D6637F16CFE5ED293F0E08@qq.com/
>
> ARM64 (rejected):
> https://lore.kernel.org/all/tencent_1873443BEECF45E0336D4C4F8C35C19FEB06@qq.com/
>
> Russell King (Oracle) wrote:
> "
> ARM gained support for CMDLINE_EXTEND in commit 4394c1244249 ("ARM:
> 6893/1: Allow for kernel command line concatenation") dated 4 May
> 2011. In this commit, CONFIG_CMDLINE _prefixes_ the boot loader
> supplied arguments.
>
> In commit 34b82026a507 ("fdt: fix extend of cmd line") dated 13
> April 2016, which _post_ _dates_ the introduction on ARM, and the
> commit even states that it's fixing the lack of appending compared
> to ARM, this adds code to drivers/of to _append_ CONFIG_CMDLINE
> to the FDT arguments which come from the boot loader.
>
> It is DT that implemented this wrongly.
>
> No, we are not going to change arch/arm to conform to something
> that was implemented in a broken way. drivers/of needs fixing
> to actually implement it as it was *originally* intended - and
> there is five years of arch/arm doing this *before* DT started
> to do it.
>
> If drivers/of maintainers also don't want to change, then I'm
> sorry, but you have to then put up with the fact that it got
> wrongly implemented by drivers/of and thus has a different
> behaviour there.
> "

Thanks for the follow-up.

Since riscv always had the behaviour you describe in your patch, I'll 
take your patch.

Thanks,

Alex

>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives