linux-kernel - Re: [PATCH v2 1/3] dt-bindings: pwm: sophgo: add pwm controller for SG2044

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250422135643.GA1132004-robh@kernel.org>
Date: Tue, 22 Apr 2025 08:56:43 -0500
From: Rob Herring <robh@...nel.org>
To: Longbin Li <looong.bin@...il.com>
Cc: Uwe Kleine-König <ukleinek@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Chen Wang <unicorn_wang@...look.com>,
	Inochi Amaoto <inochiama@...il.com>,
	Paul Walmsley <paul.walmsley@...ive.com>,
	Palmer Dabbelt <palmer@...belt.com>,
	Albert Ou <aou@...s.berkeley.edu>, Alexandre Ghiti <alex@...ti.fr>,
	linux-pwm@...r.kernel.org, devicetree@...r.kernel.org,
	sophgo@...ts.linux.dev, linux-kernel@...r.kernel.org,
	linux-riscv@...ts.infradead.org
Subject: Re: [PATCH v2 1/3] dt-bindings: pwm: sophgo: add pwm controller for
 SG2044

On Fri, Apr 18, 2025 at 10:29:44AM +0800, Longbin Li wrote:
> Add compatible string for PWM controller on SG2044.

That is clear from reading the diff. What would be useful is details on 
how the h/w is different from SG2042 (and hence not compatible with it).

> 
> Signed-off-by: Longbin Li <looong.bin@...il.com>
> ---
>  Documentation/devicetree/bindings/pwm/sophgo,sg2042-pwm.yaml | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Acked-by: Rob Herring (Arm) <robh@...nel.org>