linux-kernel - Re: [PATCH] drm/i915/pch: fix warning for coffeelake on SunrisePoint PCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aAfwS_iUrgcIRZcX@intel.com>
Date: Tue, 22 Apr 2025 15:38:51 -0400
From: Rodrigo Vivi <rodrigo.vivi@...el.com>
To: Jiajia Liu <liujiajia@...inos.cn>
CC: Jani Nikula <jani.nikula@...ux.intel.com>, Joonas Lahtinen
	<joonas.lahtinen@...ux.intel.com>, Tvrtko Ursulin <tursulin@...ulin.net>,
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, "Nemesa
 Garg" <nemesa.garg@...el.com>, Ville Syrjälä
	<ville.syrjala@...ux.intel.com>, Nitin Gote <nitin.r.gote@...el.com>, "Matt
 Roper" <matthew.d.roper@...el.com>, <intel-gfx@...ts.freedesktop.org>,
	<dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/i915/pch: fix warning for coffeelake on SunrisePoint
 PCH

On Fri, Apr 18, 2025 at 02:00:06PM +0800, Jiajia Liu wrote:
> i915/pch reports a warning on a mini PC which has a CoffeeLake-S GT2
> [UHD Graphics 630] [8086:3e92] and an ISA bridge - H110 LPC Controller
> [8086:a143].
> 
> [3.490423] i915 0000:00:02.0: [drm] Found coffeelake (device ID 3e92) integrated display version 9.00 stepping N/A
> [3.507160] ------------[ cut here ]------------
> [3.523341] i915 0000:00:02.0: [drm] drm_WARN_ON(!IS_PLATFORM(dev_priv, INTEL_SKYLAKE) && !IS_PLATFORM(dev_priv, INTEL_KABYLAKE))
> [3.523356] WARNING: CPU: 5 PID: 199 at drivers/gpu/drm/i915/soc/intel_pch.c:92 intel_pch_type+0x1c3/0xe10 [i915]
> [3.709685] CPU: 5 UID: 0 PID: 199 Comm: systemd-udevd Not tainted 6.15.0-rc2-up-fc96b232f8e7 #1 PREEMPT(voluntary)

Interesting finding! o.O

Well, please rebase your patch against drm-tip branch and resend it.
https://gitlab.freedesktop.org/drm/tip/ 

Feel free to resend with:

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@...el.com>

> 
> Signed-off-by: Jiajia Liu <liujiajia@...inos.cn>
> ---
>  drivers/gpu/drm/i915/soc/intel_pch.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/soc/intel_pch.c b/drivers/gpu/drm/i915/soc/intel_pch.c
> index 82dc7fbd1a3e..011bc9757e9b 100644
> --- a/drivers/gpu/drm/i915/soc/intel_pch.c
> +++ b/drivers/gpu/drm/i915/soc/intel_pch.c
> @@ -90,7 +90,8 @@ intel_pch_type(const struct drm_i915_private *dev_priv, unsigned short id)
>  	case INTEL_PCH_SPT_DEVICE_ID_TYPE:
>  		drm_dbg_kms(&dev_priv->drm, "Found SunrisePoint PCH\n");
>  		drm_WARN_ON(&dev_priv->drm,
> -			    !IS_SKYLAKE(dev_priv) && !IS_KABYLAKE(dev_priv));
> +			    !IS_SKYLAKE(dev_priv) && !IS_KABYLAKE(dev_priv) &&
> +			    !IS_COFFEELAKE(dev_priv));
>  		return PCH_SPT;
>  	case INTEL_PCH_SPT_LP_DEVICE_ID_TYPE:
>  		drm_dbg_kms(&dev_priv->drm, "Found SunrisePoint LP PCH\n");
> -- 
> 2.25.1
>