linux-kernel - Re: [PATCH v2 2/5] arm64: dts: ti: k3-am6*: Add boot phase flag to support MMC boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c660f217-9bb1-4ba2-8d59-851f69b41042@ti.com>
Date: Tue, 22 Apr 2025 11:15:31 +0530
From: Moteen Shah <m-shah@...com>
To: Judith Mendez <jm@...com>, Nishanth Menon <nm@...com>,
        Vignesh Raghavendra
	<vigneshr@...com>
CC: Tero Kristo <kristo@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof
 Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 2/5] arm64: dts: ti: k3-am6*: Add boot phase flag to
 support MMC boot

Hey Judith,

On 18/04/25 05:00, Judith Mendez wrote:
> The bootph-all flag was introduced in dt-schema
> (dtschema/schemas/bootph.yaml) to define node usage across
> different boot phases.
>
> For eMMC and SD boot modes, voltage regulator nodes, io-expander
> nodes, gpio nodes, and MMC nodes need to be present in all boot
> stages, so add missing bootph-all phase flag to these nodes to
> support SD boot and eMMC boot.
>
> Signed-off-by: Judith Mendez <jm@...com>
> ---
>   arch/arm64/boot/dts/ti/k3-am62-lp-sk.dts | 12 ++++++++++++
>   arch/arm64/boot/dts/ti/k3-am62a7-sk.dts  |  2 ++
>   2 files changed, 14 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am62-lp-sk.dts b/arch/arm64/boot/dts/ti/k3-am62-lp-sk.dts
> index 8e9fc00a6b3c7..aafdb90c0eb70 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62-lp-sk.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am62-lp-sk.dts
> @@ -69,6 +69,7 @@ vddshv_sdio: regulator-4 {
>   		gpios = <&main_gpio0 31 GPIO_ACTIVE_HIGH>;
>   		states = <1800000 0x0>,
>   			 <3300000 0x1>;
> +		bootph-all;
>   	};
>   };
>   
> @@ -77,12 +78,14 @@ vddshv_sdio_pins_default: vddshv-sdio-default-pins {
>   		pinctrl-single,pins = <
>   			AM62X_IOPAD(0x07c, PIN_OUTPUT, 7) /* (M19) GPMC0_CLK.GPIO0_31 */
>   		>;
> +		bootph-all;
>   	};
>   
>   	main_gpio1_ioexp_intr_pins_default: main-gpio1-ioexp-intr-default-pins {
>   		pinctrl-single,pins = <
>   			AM62X_IOPAD(0x01d4, PIN_INPUT, 7) /* (C13) UART0_RTSn.GPIO1_23 */
>   		>;
> +		bootph-all;
>   	};
>   
>   	pmic_irq_pins_default: pmic-irq-default-pins {
> @@ -118,6 +121,7 @@ exp1: gpio@22 {
>   
>   		pinctrl-names = "default";
>   		pinctrl-0 = <&main_gpio1_ioexp_intr_pins_default>;
> +		bootph-all;
>   	};
>   
>   	exp2: gpio@23 {
> @@ -229,6 +233,14 @@ &tlv320aic3106 {
>   	DVDD-supply = <&buck2_reg>;
>   };
>   
> +&main_gpio0 {
> +	bootph-all;
> +};
> +
> +&main_gpio1 {
> +	bootph-all;
> +};
> +
>   &gpmc0 {
>   	ranges = <0 0 0x00 0x51000000 0x01000000>; /* CS0 space. Min partition = 16MB */
>   };
> diff --git a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts b/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
> index 1c9d95696c839..7de4a9f139ad4 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
> @@ -313,6 +313,7 @@ AM62AX_IOPAD(0x200, PIN_INPUT_PULLUP, 0) /* (AC1) MMC0_DAT5 */
>   			AM62AX_IOPAD(0x1fc, PIN_INPUT_PULLUP, 0) /* (AD2) MMC0_DAT6 */
>   			AM62AX_IOPAD(0x1f8, PIN_INPUT_PULLUP, 0) /* (AC2) MMC0_DAT7 */
>   		>;
> +		bootph-all;
>   	};
>   
>   	main_mmc1_pins_default: main-mmc1-default-pins {
> @@ -615,6 +616,7 @@ &sdhci0 {
>   	pinctrl-names = "default";
>   	pinctrl-0 = <&main_mmc0_pins_default>;
>   	disable-wp;
> +	bootph-all;
>   };
>   

Do we have the bootph-all flags in *-uboot.dtsi for the board to boot up?
If yes we will have to clean that up after this series gets merged.

Reviewed-by: Moteen Shah <m-shah@...com>

Regards,
Moteen Shah

>   &sdhci1 {