lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <f28134bc-9994-441b-b901-b65632d7ca6b@ti.com>
Date: Tue, 22 Apr 2025 11:38:28 +0530
From: Moteen Shah <m-shah@...com>
To: Judith Mendez <jm@...com>, Nishanth Menon <nm@...com>,
        Vignesh Raghavendra
	<vigneshr@...com>
CC: Tero Kristo <kristo@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof
 Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 5/5] arm64: dts: ti: k3-am6*: Remove disable-wp for
 eMMC


On 18/04/25 05:00, Judith Mendez wrote:
> Remove disable-wp flag for eMMC nodes since this flag is
> only applicable to SD according to the binding doc
> (mmc/mmc-controller-common.yaml).
>
> For eMMC, this flag should be ignored but lets remove
> anyways to cleanup sdhci nodes.
>
> Signed-off-by: Judith Mendez <jm@...com>
> ---
>   arch/arm64/boot/dts/ti/k3-am62-phycore-som.dtsi               | 1 -
>   arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts                | 1 -
>   arch/arm64/boot/dts/ti/k3-am62a-phycore-som.dtsi              | 1 -
>   arch/arm64/boot/dts/ti/k3-am62a7-sk.dts                       | 1 -
>   arch/arm64/boot/dts/ti/k3-am62p5-sk.dts                       | 1 -
>   arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi                | 1 -
>   arch/arm64/boot/dts/ti/k3-am642-evm.dts                       | 1 -
>   arch/arm64/boot/dts/ti/k3-am654-base-board.dts                | 1 -
>   arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-common.dtsi | 1 -
>   arch/arm64/boot/dts/ti/k3-am69-sk.dts                         | 1 -
>   10 files changed, 10 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am62-phycore-som.dtsi b/arch/arm64/boot/dts/ti/k3-am62-phycore-som.dtsi
> index 55ed418c023bc..e5be92aa12189 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62-phycore-som.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62-phycore-som.dtsi
> @@ -381,7 +381,6 @@ serial_flash: flash@0 {
>   &sdhci0 {
>   	pinctrl-names = "default";
>   	pinctrl-0 = <&main_mmc0_pins_default>;
> -	disable-wp;
>   	non-removable;
>   	bootph-all;
>   	status = "okay";
> diff --git a/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts b/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts
> index 1c8b4d13fb491..72b09f9c69d8c 100644
> --- a/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts
> @@ -835,7 +835,6 @@ &sdhci0 {
>   	non-removable;
>   	pinctrl-names = "default";
>   	pinctrl-0 = <&emmc_pins_default>;
> -	disable-wp;
>   	status = "okay";
>   };
>   
> diff --git a/arch/arm64/boot/dts/ti/k3-am62a-phycore-som.dtsi b/arch/arm64/boot/dts/ti/k3-am62a-phycore-som.dtsi
> index 147d56b879843..0d4115590b9c3 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62a-phycore-som.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62a-phycore-som.dtsi
> @@ -338,7 +338,6 @@ serial_flash: flash@0 {
>   &sdhci0 {
>   	pinctrl-names = "default";
>   	pinctrl-0 = <&main_mmc0_pins_default>;
> -	disable-wp;
>   	non-removable;
>   	bootph-all;
>   	status = "okay";
> diff --git a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts b/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
> index 7de4a9f139ad4..625ce8f8958b7 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts
> @@ -615,7 +615,6 @@ &sdhci0 {
>   	non-removable;
>   	pinctrl-names = "default";
>   	pinctrl-0 = <&main_mmc0_pins_default>;
> -	disable-wp;
>   	bootph-all;
>   };
>   
> diff --git a/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts b/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
> index 43fcb57b34ebf..1025062c77d57 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
> @@ -456,7 +456,6 @@ &sdhci0 {
>   	status = "okay";
>   	non-removable;
>   	ti,driver-strength-ohm = <50>;
> -	disable-wp;
>   	bootph-all;
>   };
>   
> diff --git a/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi b/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi
> index 561916c6e151c..9d933e837dd4b 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi
> @@ -437,7 +437,6 @@ &sdhci0 {
>   	non-removable;
>   	pinctrl-names = "default";
>   	pinctrl-0 = <&main_mmc0_pins_default>;
> -	disable-wp;
>   };
>   
>   &sdhci1 {
> diff --git a/arch/arm64/boot/dts/ti/k3-am642-evm.dts b/arch/arm64/boot/dts/ti/k3-am642-evm.dts
> index f8ec40523254b..5c6197ba842e4 100644
> --- a/arch/arm64/boot/dts/ti/k3-am642-evm.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am642-evm.dts
> @@ -597,7 +597,6 @@ &sdhci0 {
>   	status = "okay";
>   	non-removable;
>   	ti,driver-strength-ohm = <50>;
> -	disable-wp;
>   	bootph-all;
>   };
>   
> diff --git a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> index aa7139cc8a92b..c30425960398e 100644
> --- a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> @@ -456,7 +456,6 @@ &sdhci0 {
>   	bus-width = <8>;
>   	non-removable;
>   	ti,driver-strength-ohm = <50>;
> -	disable-wp;
>   };
>   
>   /*
> diff --git a/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-common.dtsi b/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-common.dtsi
> index ae842b85b70de..12af6cb7f65cf 100644
> --- a/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-common.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-common.dtsi
> @@ -50,5 +50,4 @@ &sdhci0 {
>   	bus-width = <8>;
>   	non-removable;
>   	ti,driver-strength-ohm = <50>;
> -	disable-wp;
>   };
> diff --git a/arch/arm64/boot/dts/ti/k3-am69-sk.dts b/arch/arm64/boot/dts/ti/k3-am69-sk.dts
> index b85227052f97e..f28375629739c 100644
> --- a/arch/arm64/boot/dts/ti/k3-am69-sk.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am69-sk.dts
> @@ -940,7 +940,6 @@ &main_sdhci0 {
>   	status = "okay";
>   	non-removable;
>   	ti,driver-strength-ohm = <50>;
> -	disable-wp;
>   };

Reviewed-by: Moteen Shah <m-shah@...com>

Regards,
Moteen Shah

>   
>   &main_sdhci1 {

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ