linux-kernel - Re: [RFC PATCH] nvmet: Make blksize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a1641ac2-abe4-458a-bdb0-76921f25b108@nvidia.com>
Date: Tue, 22 Apr 2025 06:50:06 +0000
From: Chaitanya Kulkarni <chaitanyak@...dia.com>
To: Richard Weinberger <richard@....at>, "linux-nvme@...ts.infradead.org"
	<linux-nvme@...ts.infradead.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Chaitanya
 Kulkarni <chaitanyak@...dia.com>, "sagi@...mberg.me" <sagi@...mberg.me>,
	"hch@....de" <hch@....de>, "upstream+nvme@...ma-star.at"
	<upstream+nvme@...ma-star.at>
Subject: Re: [RFC PATCH] nvmet: Make blksize_shift configurable

On 4/18/25 02:08, Richard Weinberger wrote:
> +static ssize_t nvmet_ns_blksize_shift_show(struct config_item *item, char *page)
> +{
> +	return sysfs_emit(page, "%d\n", to_nvmet_ns(item)->blksize_shift);
> +}
> +

I believe ns->blksize_shift is u32 to do we need %u ? unless we need to
re-interpret that value in int which I failed to understand.

if not please ignore this comment ...

-ck