linux-kernel - Re: [RFC PATCH] nvmet: Make blksize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250422081644.GB411@lst.de>
Date: Tue, 22 Apr 2025 10:16:44 +0200
From: Christoph Hellwig <hch@....de>
To: Richard Weinberger <richard@...ma-star.at>
Cc: linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Richard Weinberger <richard@....at>, kch@...dia.com,
	sagi@...mberg.me, hch@....de, upstream+nvme@...ma-star.at,
	Damien Le Moal <dlemoal@...nel.org>
Subject: Re: [RFC PATCH] nvmet: Make blksize_shift configurable

On Fri, Apr 18, 2025 at 11:56:30AM +0200, Richard Weinberger wrote:
> TBH, I'm not sure whether it makes actually sense for the bdev case to make
> blksize_shift configurable.

> It's also worth discussing whether we should limit blksize_shift to a specific
> range. Right now, any shift is accepted, and it is up to the user to
> use a sane value.

It should have a hard lower bound of 512 bytes (9) and for direct I/O and
the bdev backend the reported dio alignment.

The upper bound is capped by the nvme_lbaf field being a 8-bit value on
the wire, no real need to require anything lower than that probably.