linux-kernel - Re: [PATCH v2 2/2] khugepaged: Refactor trace_mm_khugepaged_scan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <31ed0cc4-89a3-4f92-a611-06322c5d248b@redhat.com>
Date: Tue, 22 Apr 2025 10:50:03 +0200
From: David Hildenbrand <david@...hat.com>
To: Yang Shi <yang@...amperecomputing.com>, nifan.cxl@...il.com,
 rostedt@...dmis.org, mhiramat@...nel.org, willy@...radead.org
Cc: akpm@...ux-foundation.org, fan.ni@...sung.com,
 linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org,
 linux-mm@...ck.org, npache@...hat.com, mcgrof@...nel.org,
 a.manzanares@...sung.com, dave@...olabs.net
Subject: Re: [PATCH v2 2/2] khugepaged: Refactor
 trace_mm_khugepaged_scan_pmd() to take folio instead of page

On 22.04.25 00:40, Yang Shi wrote:
> 
> 
> On 4/18/25 11:34 AM, nifan.cxl@...il.com wrote:
>> From: Fan Ni <fan.ni@...sung.com>
>>
>> trace_mm_khugepaged_scan_pmd() is only called in
>> hpage_collapse_scan_pmd(), where the head page of a folio is passed in,
>> so refactor it to take folio directly.
>>
>> Signed-off-by: Fan Ni <fan.ni@...sung.com>
>> ---
>> This is a new patch added to the series.
> 
> The change looks good to me. Reviewed-by: Yang Shi
> <yang@...amperecomputing.com>
> 
> But I think the two patches can be squashed into one patch.

Agreed, something like

"khugepaged: pass folio instead of head page to trace events"

Acked-by: David Hildenbrand <david@...hat.com>

-- 
Cheers,

David / dhildenb