linux-kernel - Re: [PATCH v3 2/2] cpufreq: tegra124: Allow building as a module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250422101053.kjg4dctendvcg3hv@vireshk-i7>
Date: Tue, 22 Apr 2025 15:40:53 +0530
From: Viresh Kumar <viresh.kumar@...aro.org>
To: webgeek1234@...il.com
Cc: "Rafael J. Wysocki" <rafael@...nel.org>,
	Thierry Reding <thierry.reding@...il.com>,
	Jonathan Hunter <jonathanh@...dia.com>, linux-pm@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org
Subject: Re: [PATCH v3 2/2] cpufreq: tegra124: Allow building as a module

On 21-04-25, 12:33, Aaron Kling via B4 Relay wrote:
> +static void __exit tegra_cpufreq_module_exit(void)

Shouldn't name be tegra_cpufreq_exit() ? Just like
tegra_cpufreq_init().


> +{
> +	struct tegra124_cpufreq_priv *priv;
> +
> +	if (platform_device && !IS_ERR(platform_device)) {
> +		priv = dev_get_drvdata(&platform_device->dev);
> +
> +		clk_put(priv->pllp_clk);
> +		clk_put(priv->pllx_clk);
> +		clk_put(priv->dfll_clk);
> +		clk_put(priv->cpu_clk);

Shouldn't this be done from remove() as the resources were acquired in
probe() ? tegra_cpufreq_exit() should only revert what's done
by tegra_cpufreq_init().

-- 
viresh