linux-kernel - Re: [PATCH 14/29] x86/boot/e820: Clean up __e820__range

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aAdrJGBTiC75KPn-@smile.fi.intel.com>
Date: Tue, 22 Apr 2025 13:10:44 +0300
From: Andy Shevchenko <andy@...nel.org>
To: Ingo Molnar <mingo@...nel.org>
Cc: linux-kernel@...r.kernel.org, Arnd Bergmann <arnd@...nel.org>,
	Borislav Petkov <bp@...en8.de>, Juergen Gross <jgross@...e.com>,
	"H . Peter Anvin" <hpa@...or.com>,
	Kees Cook <keescook@...omium.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Mike Rapoport <rppt@...nel.org>,
	Paul Menzel <pmenzel@...gen.mpg.de>,
	Peter Zijlstra <peterz@...radead.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	David Woodhouse <dwmw@...zon.co.uk>
Subject: Re: [PATCH 14/29] x86/boot/e820: Clean up __e820__range_add() a bit

On Mon, Apr 21, 2025 at 08:51:54PM +0200, Ingo Molnar wrote:
>  - Use 'idx' index variable instead of a weird 'x'
>  - Make the error message E820-specific
>  - Group the code a bit better

...

> -	if (x >= ARRAY_SIZE(table->entries)) {
> -		pr_err("too many entries; ignoring [mem %#010llx-%#010llx]\n",
> -		       start, start + size - 1);
> +	if (idx >= ARRAY_SIZE(table->entries)) {
> +		pr_err("too many E820 table entries; ignoring [mem %#010llx-%#010llx]\n",
> +		       start, start + size-1);

size - 1 ?

>  		return;
>  	}

-- 
With Best Regards,
Andy Shevchenko