linux-kernel - RE: [EXTERNAL] Re: [PATCH v2 2/3] net: mana: Add sched HTB offload support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <MN0PR21MB3437359D91F059D83AF929F0CABA2@MN0PR21MB3437.namprd21.prod.outlook.com>
Date: Wed, 23 Apr 2025 15:27:16 +0000
From: Haiyang Zhang <haiyangz@...rosoft.com>
To: Jakub Kicinski <kuba@...nel.org>, Erni Sri Satya Vennela
	<ernis@...ux.microsoft.com>
CC: KY Srinivasan <kys@...rosoft.com>, "wei.liu@...nel.org"
	<wei.liu@...nel.org>, Dexuan Cui <decui@...rosoft.com>,
	"andrew+netdev@...n.ch" <andrew+netdev@...n.ch>, "davem@...emloft.net"
	<davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>,
	"pabeni@...hat.com" <pabeni@...hat.com>, Long Li <longli@...rosoft.com>,
	Konstantin Taranov <kotaranov@...rosoft.com>, "horms@...nel.org"
	<horms@...nel.org>, "mhklinux@...look.com" <mhklinux@...look.com>,
	"pasha.tatashin@...een.com" <pasha.tatashin@...een.com>,
	"kent.overstreet@...ux.dev" <kent.overstreet@...ux.dev>,
	"brett.creeley@....com" <brett.creeley@....com>,
	"schakrabarti@...ux.microsoft.com" <schakrabarti@...ux.microsoft.com>,
	"shradhagupta@...ux.microsoft.com" <shradhagupta@...ux.microsoft.com>,
	"ssengar@...ux.microsoft.com" <ssengar@...ux.microsoft.com>,
	"rosenp@...il.com" <rosenp@...il.com>, Paul Rosswurm <paulros@...rosoft.com>,
	"linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [EXTERNAL] Re: [PATCH v2 2/3] net: mana: Add sched HTB offload
 support



> -----Original Message-----
> From: Jakub Kicinski <kuba@...nel.org>
> Sent: Tuesday, April 22, 2025 8:19 PM
> To: Erni Sri Satya Vennela <ernis@...ux.microsoft.com>
> Cc: KY Srinivasan <kys@...rosoft.com>; Haiyang Zhang
> <haiyangz@...rosoft.com>; wei.liu@...nel.org; Dexuan Cui
> <decui@...rosoft.com>; andrew+netdev@...n.ch; davem@...emloft.net;
> edumazet@...gle.com; pabeni@...hat.com; Long Li <longli@...rosoft.com>;
> Konstantin Taranov <kotaranov@...rosoft.com>; horms@...nel.org;
> mhklinux@...look.com; pasha.tatashin@...een.com;
> kent.overstreet@...ux.dev; brett.creeley@....com;
> schakrabarti@...ux.microsoft.com; shradhagupta@...ux.microsoft.com;
> ssengar@...ux.microsoft.com; rosenp@...il.com; Paul Rosswurm
> <paulros@...rosoft.com>; linux-hyperv@...r.kernel.org;
> netdev@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [EXTERNAL] Re: [PATCH v2 2/3] net: mana: Add sched HTB offload
> support
> 
> On Tue, 22 Apr 2025 12:48:30 -0700 Erni Sri Satya Vennela wrote:
> > On Mon, Apr 21, 2025 at 05:03:49PM -0700, Jakub Kicinski wrote:
> > > On Sun, 20 Apr 2025 23:33:39 -0700 Erni Sri Satya Vennela wrote:
> > > > This controller can offload only one HTB leaf.
> > >
> > We selected tc-htb for our current use case because we plan to support
> > multiple speed classes in the future.
> 
> Which net-shapers also support.

Thanks for pointing that out...
But for easier usage with existing tc tool for customers, can we still
use tc-htb offload? Does using tc-htb offload for speed clamping break
any coding convention or API specs?

Thanks,
- Haiyang