linux-kernel - Re: [PATCH 1/3] iio: adc: mcp3911: fix device dependent mappings for conversion result registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aAkWfw_csgBpU6w_@smile.fi.intel.com>
Date: Wed, 23 Apr 2025 19:34:07 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Marcus Folkesson <marcus.folkesson@...il.com>
Cc: Kent Gustavsson <kent@...oris.se>, Jonathan Cameron <jic23@...nel.org>,
	Lars-Peter Clausen <lars@...afoo.de>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Jonathan Cameron <Jonathan.Cameron@...wei.com>,
	linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
	Kent Gustavsson <nedo80@...il.com>, devicetree@...r.kernel.org,
	Lukas Rauber <lukas.rauber@...itza.de>
Subject: Re: [PATCH 1/3] iio: adc: mcp3911: fix device dependent mappings for
 conversion result registers

On Wed, Apr 23, 2025 at 04:46:49PM +0200, Marcus Folkesson wrote:
> The conversion result registers differs between devices. Make sure the
> mapping is correct by using a device dependent .get_raw() callback function.
> 
> Fixes: 732ad34260d3 ("iio: adc: mcp3911: add support for the whole MCP39xx family")

> 

Shouldn't be blank line(s) in the tag block.

> Co-developed-by: Lukas Rauber <lukas.rauber@...itza.de>
> Signed-off-by: Lukas Rauber <lukas.rauber@...itza.de>
> Signed-off-by: Marcus Folkesson <marcus.folkesson@...il.com>
> ---

...

> +	*val = sign_extend32(uval, 23);

With that, replace bits.h by bitops.h at the top of the file.

-- 
With Best Regards,
Andy Shevchenko