linux-kernel - Re: [PATCH] splice: remove duplicate noinline from pipe_clear

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c3880483-7cd6-4151-9af8-f6a1be9977c9@kernel.dk>
Date: Wed, 23 Apr 2025 14:10:39 -0600
From: Jens Axboe <axboe@...nel.dk>
To: "T.J. Mercier" <tjmercier@...gle.com>,
 Alexander Viro <viro@...iv.linux.org.uk>,
 Christian Brauner <brauner@...nel.org>, Jan Kara <jack@...e.cz>
Cc: linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] splice: remove duplicate noinline from pipe_clear_nowait

On 4/23/25 12:00 PM, T.J. Mercier wrote:
> pipe_clear_nowait has two noinline macros, but we only need one.
> 
> I checked the whole tree, and this is the only occurrence:
> 
> $ grep -r "noinline .* noinline"
> fs/splice.c:static noinline void noinline pipe_clear_nowait(struct file *file)
> $

Funky! Obivously looks fine:

Reviewed-by: Jens Axboe <axboe@...nel.dk>

-- 
Jens Axboe