linux-kernel - Re: [PATCH v5] remoteproc: Add device awake calls in rproc boot and shutdown path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <76366b84-29d1-8b3a-d6a1-224d8cb68946@quicinc.com>
Date: Wed, 23 Apr 2025 11:56:37 +0530
From: Souradeep Chowdhury <quic_schowdhu@...cinc.com>
To: Mathieu Poirier <mathieu.poirier@...aro.org>,
        Bjorn Andersson
	<andersson@...nel.org>,
        <linux-remoteproc@...r.kernel.org>, <linux-kernel@...r.kernel.org>
CC: Mukesh Ojha <mukesh.ojha@....qualcomm.com>
Subject: Re: [PATCH v5] remoteproc: Add device awake calls in rproc boot and
 shutdown path

Gentle Reminder

On 4/8/2025 4:13 PM, Souradeep Chowdhury wrote:
> Add device awake calls in case of rproc boot and rproc shutdown path.
> Currently, device awake call is only present in the recovery path
> of remoteproc. If an user stops and starts rproc by using the sysfs
> interface, then on pm suspension the firmware fails to load as the
> request_firmware call under adsp_load relies on usermodehelper
> process which gets freezed on pm suspension. Add device awake calls
> to fix this.
>
> Signed-off-by: Souradeep Chowdhury <quic_schowdhu@...cinc.com>
> Reviewed-by: Mukesh Ojha <mukesh.ojha@....qualcomm.com>
> ---
> Changes in v5
>
> *Added more details to commit description
>
> Changes in v4
>
> *Remove stability from mailing list
> *Remove the extra tab in v3
> *Change the commit description
>
>   drivers/remoteproc/remoteproc_core.c | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
> index c2cf0d277729..5d6c4e694b4c 100644
> --- a/drivers/remoteproc/remoteproc_core.c
> +++ b/drivers/remoteproc/remoteproc_core.c
> @@ -1917,6 +1917,7 @@ int rproc_boot(struct rproc *rproc)
>   		return -EINVAL;
>   	}
>   
> +	pm_stay_awake(rproc->dev.parent);
>   	dev = &rproc->dev;
>   
>   	ret = mutex_lock_interruptible(&rproc->lock);
> @@ -1961,6 +1962,7 @@ int rproc_boot(struct rproc *rproc)
>   		atomic_dec(&rproc->power);
>   unlock_mutex:
>   	mutex_unlock(&rproc->lock);
> +	pm_relax(rproc->dev.parent);
>   	return ret;
>   }
>   EXPORT_SYMBOL(rproc_boot);
> @@ -1991,6 +1993,7 @@ int rproc_shutdown(struct rproc *rproc)
>   	struct device *dev = &rproc->dev;
>   	int ret = 0;
>   
> +	pm_stay_awake(rproc->dev.parent);
>   	ret = mutex_lock_interruptible(&rproc->lock);
>   	if (ret) {
>   		dev_err(dev, "can't lock rproc %s: %d\n", rproc->name, ret);
> @@ -2027,6 +2030,7 @@ int rproc_shutdown(struct rproc *rproc)
>   	rproc->table_ptr = NULL;
>   out:
>   	mutex_unlock(&rproc->lock);
> +	pm_relax(rproc->dev.parent);
>   	return ret;
>   }
>   EXPORT_SYMBOL(rproc_shutdown);