linux-kernel - Re: [PATCH v2 1/9] opp: add new helper API dev_pm_opp_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <66e30117-3944-4731-955e-62d1c78ff456@quicinc.com>
Date: Wed, 23 Apr 2025 11:58:15 +0530
From: Praveen Talari <quic_ptalari@...cinc.com>
To: Viresh Kumar <viresh.kumar@...aro.org>
CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby
	<jirislaby@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski
	<krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Bjorn Andersson
	<andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>,
        Viresh Kumar
	<vireshk@...nel.org>, Nishanth Menon <nm@...com>,
        Stephen Boyd
	<sboyd@...nel.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        <linux-arm-msm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-serial@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-pm@...r.kernel.org>, <psodagud@...cinc.com>,
        <djaggi@...cinc.com>, <quic_msavaliy@...cinc.com>,
        <quic_vtanuku@...cinc.com>, <quic_arandive@...cinc.com>,
        <quic_mnaresh@...cinc.com>, <quic_shazhuss@...cinc.com>,
        Nikunj Kela <quic_nkela@...cinc.com>
Subject: Re: [PATCH v2 1/9] opp: add new helper API dev_pm_opp_set_level()

Hi Viresh

Thank you for reviewing.

On 4/23/2025 11:06 AM, Viresh Kumar wrote:
> On 22-04-25, 22:37, Praveen Talari wrote:
>> most of helper APIs in core.c and even i don't see any helper API in
>> pm_opp.c.
> This is more of a wrapper over the existing C routines which is being
> added to reduce some boilerplate code from drivers. And so it makes
> sense to add this as an inline helper. May be there are others which
> can be moved too.
i agree and move to pm_opp.h. Will update in next
>
>> as reference of APIs in core.c, i have used  -EINVAl instead of IS_ERR(opp).
> That would likely be wrong, maybe we should fix those too.
Ok i will update as per if statement check for return as well.
>