linux-kernel - Re: [PATCH v13 3/9] kexec: define functions to map and unmap segments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f2f4a873489b28d3baa4ac1f6073a49fe888d120.camel@linux.ibm.com>
Date: Tue, 22 Apr 2025 20:29:44 -0400
From: Mimi Zohar <zohar@...ux.ibm.com>
To: steven chen <chenste@...ux.microsoft.com>, stefanb@...ux.ibm.com,
        roberto.sassu@...weicloud.com, roberto.sassu@...wei.com,
        eric.snowberg@...cle.com, ebiederm@...ssion.com, paul@...l-moore.com,
        code@...icks.com, bauermann@...abnow.com,
        linux-integrity@...r.kernel.org, kexec@...ts.infradead.org,
        linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: madvenka@...ux.microsoft.com, nramas@...ux.microsoft.com,
        James.Bottomley@...senPartnership.com, bhe@...hat.com,
        vgoyal@...hat.com, dyoung@...hat.com
Subject: Re: [PATCH v13 3/9] kexec: define functions to map and unmap
 segments

On Mon, 2025-04-21 at 15:25 -0700, steven chen wrote:
> From: Steven Chen <chenste@...ux.microsoft.com>
> 
> Implement kimage_map_segment() to enable IMA to map the measurement log 
> list to the kimage structure during the kexec 'load' stage. This function
> gathers the source pages within the specified address range, and maps them
> to a contiguous virtual address range.
> 
> This is a preparation for later usage.
> 
> Implement kimage_unmap_segment() for unmapping segments using vunmap().
> 
> Cc: Eric Biederman <ebiederm@...ssion.com>
> Cc: Baoquan He <bhe@...hat.com> 
> Cc: Vivek Goyal <vgoyal@...hat.com>
> Cc: Dave Young <dyoung@...hat.com>
> Co-developed-by: Tushar Sugandhi <tusharsu@...ux.microsoft.com>
> Signed-off-by: Tushar Sugandhi <tusharsu@...ux.microsoft.com>
> Signed-off-by: steven chen <chenste@...ux.microsoft.com>

Checkpatch.pl is complaining that the Signed-off-by tag does not matches the
"From:" line only on this patch.  I've updated your Signed-off-by tag to match
the "From:" line above.

> Acked-by: Baoquan He <bhe@...hat.com>

Missing from v13 is Stefan's Tested-by tag.  As the code hasn't changed, I've
added it.  In the future, please don't forget to add the tags.

Stefen Berger spent quite a bit of time reviewing this patch set, but with v13
most of his Reviewed-by tags are missing. Stefan?

For now the patch set is staged in the next-integrity-testing branch.

thanks,

Mimi