linux-kernel - Re: [PATCH v13 3/9] kexec: define functions to map and unmap segments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <99e18151-2866-4646-8532-3d10d63279b9@linux.microsoft.com>
Date: Wed, 23 Apr 2025 08:29:43 -0700
From: steven chen <chenste@...ux.microsoft.com>
To: Mimi Zohar <zohar@...ux.ibm.com>, stefanb@...ux.ibm.com,
 roberto.sassu@...weicloud.com, roberto.sassu@...wei.com,
 eric.snowberg@...cle.com, ebiederm@...ssion.com, paul@...l-moore.com,
 code@...icks.com, bauermann@...abnow.com, linux-integrity@...r.kernel.org,
 kexec@...ts.infradead.org, linux-security-module@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: madvenka@...ux.microsoft.com, nramas@...ux.microsoft.com,
 James.Bottomley@...senPartnership.com, bhe@...hat.com, vgoyal@...hat.com,
 dyoung@...hat.com
Subject: Re: [PATCH v13 3/9] kexec: define functions to map and unmap segments

On 4/22/2025 5:29 PM, Mimi Zohar wrote:
> On Mon, 2025-04-21 at 15:25 -0700, steven chen wrote:
>> From: Steven Chen <chenste@...ux.microsoft.com>
>>
>> Implement kimage_map_segment() to enable IMA to map the measurement log
>> list to the kimage structure during the kexec 'load' stage. This function
>> gathers the source pages within the specified address range, and maps them
>> to a contiguous virtual address range.
>>
>> This is a preparation for later usage.
>>
>> Implement kimage_unmap_segment() for unmapping segments using vunmap().
>>
>> Cc: Eric Biederman <ebiederm@...ssion.com>
>> Cc: Baoquan He <bhe@...hat.com>
>> Cc: Vivek Goyal <vgoyal@...hat.com>
>> Cc: Dave Young <dyoung@...hat.com>
>> Co-developed-by: Tushar Sugandhi <tusharsu@...ux.microsoft.com>
>> Signed-off-by: Tushar Sugandhi <tusharsu@...ux.microsoft.com>
>> Signed-off-by: steven chen <chenste@...ux.microsoft.com>
> Checkpatch.pl is complaining that the Signed-off-by tag does not matches the
> "From:" line only on this patch.  I've updated your Signed-off-by tag to match
> the "From:" line above.
>
>> Acked-by: Baoquan He <bhe@...hat.com>
> Missing from v13 is Stefan's Tested-by tag.  As the code hasn't changed, I've
> added it.  In the future, please don't forget to add the tags.
>
> Stefen Berger spent quite a bit of time reviewing this patch set, but with v13
> most of his Reviewed-by tags are missing. Stefan?
>
> For now the patch set is staged in the next-integrity-testing branch.
>
> thanks,
>
> Mimi

Hi Mimi,

Could you help to add
Tested-by tag for this patch set: "Tested-by: Stefan Berger 
<stefanb@...ux.ibm.com> # ppc64/kvm"
Reviewed-by tags "Reviewed-by: Stefan Berger <stefanb@...ux.ibm.com>" to 
patch 1, 5, 6, 9.

Thanks a lot.

Hi Stefen,

Thanks for your help all the time and sorry missing tags to show your work.

Sorry again,

Steven