linux-kernel - Re: [PATCH] input: ili210x: Fix uninitialized symbols in ili251x_firmware_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aAiWvzzSSWraeRdr@graute-macos>
Date: Wed, 23 Apr 2025 07:30:18 +0000
From: Oliver Graute <oliver.graute@...oconnector.com>
To: Purva Yeshi <purvayeshi550@...il.com>
CC: "dmitry.torokhov@...il.com" <dmitry.torokhov@...il.com>,
	"yujiaoliang@...o.com" <yujiaoliang@...o.com>, "jkeeping@...usicbrands.com"
	<jkeeping@...usicbrands.com>, "viro@...iv.linux.org.uk"
	<viro@...iv.linux.org.uk>, "linux-input@...r.kernel.org"
	<linux-input@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] input: ili210x: Fix uninitialized symbols in
 ili251x_firmware_to_buffer

On 19/04/25, Purva Yeshi wrote:
> Fix Smatch-detected issue:
> 
> drivers/input/touchscreen/ili210x.c:621 ili251x_firmware_to_buffer()
> error: uninitialized symbol 'fw_addr'.
> drivers/input/touchscreen/ili210x.c:621 ili251x_firmware_to_buffer()
> error: uninitialized symbol 'fw_len'.
> 
> Initialize 'fw_addr' and 'fw_len' to 0 in ili251x_firmware_to_buffer()
> to avoid uninitialized use warnings reported by smatch.
> 
> Although the while loop ensures both variables are always assigned before
> use, initializing them silences false positives.
> 
> Signed-off-by: Purva Yeshi <purvayeshi550@...il.com>

Reviewed-by: Oliver Graute <oliver.graute@...oconnector.com>