linux-kernel - Re: [PATCH] input: ili210x: Fix uninitialized symbols in ili251x_firmware_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <k6giuutuolfpx4yozicqure3gfkijr3wfv5xxm6qnpk2rg7l7i@524rayrahmja>
Date: Mon, 28 Apr 2025 18:24:23 -0700
From: "dmitry.torokhov@...il.com" <dmitry.torokhov@...il.com>
To: Oliver Graute <oliver.graute@...oconnector.com>
Cc: Purva Yeshi <purvayeshi550@...il.com>, 
	"yujiaoliang@...o.com" <yujiaoliang@...o.com>, "jkeeping@...usicbrands.com" <jkeeping@...usicbrands.com>, 
	"viro@...iv.linux.org.uk" <viro@...iv.linux.org.uk>, "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>, 
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] input: ili210x: Fix uninitialized symbols in
 ili251x_firmware_to_buffer

On Wed, Apr 23, 2025 at 07:30:18AM +0000, Oliver Graute wrote:
> On 19/04/25, Purva Yeshi wrote:
> > Fix Smatch-detected issue:
> > 
> > drivers/input/touchscreen/ili210x.c:621 ili251x_firmware_to_buffer()
> > error: uninitialized symbol 'fw_addr'.
> > drivers/input/touchscreen/ili210x.c:621 ili251x_firmware_to_buffer()
> > error: uninitialized symbol 'fw_len'.
> > 
> > Initialize 'fw_addr' and 'fw_len' to 0 in ili251x_firmware_to_buffer()
> > to avoid uninitialized use warnings reported by smatch.
> > 
> > Although the while loop ensures both variables are always assigned before
> > use, initializing them silences false positives.
> > 
> > Signed-off-by: Purva Yeshi <purvayeshi550@...il.com>
> 
> Reviewed-by: Oliver Graute <oliver.graute@...oconnector.com>

No, we will not be adding gratuitous initializations just to appease
smatch.

That said, "do {} while (rec);" loop might work better here and also
might allow smatch to recognize that both variables are not used
uninitialized. I would accept such a patch.

Thanks.

-- 
Dmitry