linux-kernel - Re: [PATCH net] net: phy: leds: fix memory leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <174537182950.2107432.13440582690052227566.git-patchwork-notify@kernel.org>
Date: Wed, 23 Apr 2025 01:30:29 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Qingfang Deng <dqfext@...il.com>
Cc: andrew@...n.ch, hkallweit1@...il.com, linux@...linux.org.uk,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
 mail@...iej.szmigiero.name, nathan.sullivan@...com, josh.cartwright@...com,
 zach.brown@...com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 gch981213@...il.com, qingfang.deng@...lower.com.cn, hao.guan@...lower.com.cn
Subject: Re: [PATCH net] net: phy: leds: fix memory leak

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Thu, 17 Apr 2025 11:25:56 +0800 you wrote:
> From: Qingfang Deng <qingfang.deng@...lower.com.cn>
> 
> A network restart test on a router led to an out-of-memory condition,
> which was traced to a memory leak in the PHY LED trigger code.
> 
> The root cause is misuse of the devm API. The registration function
> (phy_led_triggers_register) is called from phy_attach_direct, not
> phy_probe, and the unregister function (phy_led_triggers_unregister)
> is called from phy_detach, not phy_remove. This means the register and
> unregister functions can be called multiple times for the same PHY
> device, but devm-allocated memory is not freed until the driver is
> unbound.
> 
> [...]

Here is the summary with links:
  - [net] net: phy: leds: fix memory leak
    https://git.kernel.org/netdev/net/c/b7f0ee992adf

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html