linux-kernel - Re: [PATCH next] misc: ti_fpc202: Fix off by one in probe()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <48972165-8cda-4db4-a5d9-299854afb112@app.fastmail.com>
Date: Wed, 23 Apr 2025 12:49:06 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: "Dan Carpenter" <dan.carpenter@...aro.org>,
 "Romain Gantois" <romain.gantois@...tlin.com>
Cc: "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
 "Linus Walleij" <linus.walleij@...aro.org>,
 "Wolfram Sang" <wsa+renesas@...g-engineering.com>,
 "Andi Shyti" <andi.shyti@...nel.org>, linux-kernel@...r.kernel.org,
 kernel-janitors@...r.kernel.org
Subject: Re: [PATCH next] misc: ti_fpc202: Fix off by one in probe()

On Wed, Apr 23, 2025, at 10:22, Dan Carpenter wrote:
> The "port_id" is used as an array index into the struct fpc202_priv
> priv->addr_caches[] array in fpc202_write_dev_addr().  It's a 2 by 2
> array so if "port_id" is FPC202_NUM_PORTS (2) then it's one element
> out of bounds.  Change the > to >= to fix this bug.
>
> Fixes: 1e5c9b1efa1c ("misc: add FPC202 dual port controller driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---

Acked-by: Arnd Bergmann <arnd@...db.de>