linux-kernel - Re: [PATCH] dmaengine: ARM_DMA350 should depend on ARM/ARM64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b1f19b31-3535-4bb5-bcef-6f17ad2a0ee6@arm.com>
Date: Wed, 23 Apr 2025 11:59:30 +0100
From: Robin Murphy <robin.murphy@....com>
To: Geert Uytterhoeven <geert+renesas@...der.be>,
 Vinod Koul <vkoul@...nel.org>
Cc: dmaengine@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dmaengine: ARM_DMA350 should depend on ARM/ARM64

On 2025-04-22 7:11 pm, Geert Uytterhoeven wrote:
> The Arm DMA-350 controller is only present on Arm-based SoCs.

Do you know that for sure? I certainly don't. This is a licensable, 
self-contained DMA controller IP with no relationship whatsoever to any 
particular CPU ISA - our other system IP products have turned up in the 
wild paired with non-Arm CPUs, so I don't see any reason that DMA-350 
wouldn't either.

Would you propose making all the DesignWare drivers depend on ARC 
because those happen to come from the same company too? ;)

Thanks,
Robin.

>  Hence add
> dependencies on ARM and ARM64, to prevent asking the user about this
> driver when configuring a kernel for a non-Arm architecture.
> 
> Fixes: 5d099706449d54b4 ("dmaengine: Add Arm DMA-350 driver")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
>   drivers/dma/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> index 8109f73baf10fc3b..db87dd2a07f7606e 100644
> --- a/drivers/dma/Kconfig
> +++ b/drivers/dma/Kconfig
> @@ -95,6 +95,7 @@ config APPLE_ADMAC
>   
>   config ARM_DMA350
>   	tristate "Arm DMA-350 support"
> +	depends on ARM || ARM64 || COMPILE_TEST
>   	select DMA_ENGINE
>   	select DMA_VIRTUAL_CHANNELS
>   	help