linux-kernel - Re: [PATCH] dmaengine: ARM_DMA350 should depend on ARM/ARM64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdVJKA8zYETKJTRAwg6=+EuTq4YqbFO32K4+py9YNsD1Gw@mail.gmail.com>
Date: Wed, 23 Apr 2025 13:11:27 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Robin Murphy <robin.murphy@....com>
Cc: Vinod Koul <vkoul@...nel.org>, dmaengine@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dmaengine: ARM_DMA350 should depend on ARM/ARM64

Hi Robin,

On Wed, 23 Apr 2025 at 12:59, Robin Murphy <robin.murphy@....com> wrote:
> On 2025-04-22 7:11 pm, Geert Uytterhoeven wrote:
> > The Arm DMA-350 controller is only present on Arm-based SoCs.
>
> Do you know that for sure? I certainly don't. This is a licensable,
> self-contained DMA controller IP with no relationship whatsoever to any
> particular CPU ISA - our other system IP products have turned up in the
> wild paired with non-Arm CPUs, so I don't see any reason that DMA-350
> wouldn't either.

The dependency can always be relaxed later, when the need arises.
Note that currently there are no users at all...

Unlike drivers for other AMBA devices, this driver is a plain platform
driver, not an amba driver, so it does not depend on ARM_AMBA.

> Would you propose making all the DesignWare drivers depend on ARC
> because those happen to come from the same company too? ;)

No, I am fully aware they may appear anywhere.

> >  Hence add
> > dependencies on ARM and ARM64, to prevent asking the user about this
> > driver when configuring a kernel for a non-Arm architecture.
> >
> > Fixes: 5d099706449d54b4 ("dmaengine: Add Arm DMA-350 driver")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> > ---
> >   drivers/dma/Kconfig | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> > index 8109f73baf10fc3b..db87dd2a07f7606e 100644
> > --- a/drivers/dma/Kconfig
> > +++ b/drivers/dma/Kconfig
> > @@ -95,6 +95,7 @@ config APPLE_ADMAC
> >
> >   config ARM_DMA350
> >       tristate "Arm DMA-350 support"
> > +     depends on ARM || ARM64 || COMPILE_TEST
> >       select DMA_ENGINE
> >       select DMA_VIRTUAL_CHANNELS
> >       help

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds