linux-kernel - Re: [PATCH] PCI: dwc: ep: Use FIELD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aApANPRB7f1mOWDa@ryzen>
Date: Thu, 24 Apr 2025 15:44:20 +0200
From: Niklas Cassel <cassel@...nel.org>
To: Hans Zhang <18255117159@....com>
Cc: lpieralisi@...nel.org, bhelgaas@...gle.com, jingoohan1@...il.com,
	manivannan.sadhasivam@...aro.org, kw@...ux.com, robh@...nel.org,
	thomas.richard@...tlin.com, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCI: dwc: ep: Use FIELD_GET()

On Mon, Apr 21, 2025 at 07:45:48PM +0800, Hans Zhang wrote:
> Use FIELD_GET() and FIELD_PREP() to remove dependences on the field
> position, i.e., the shift value. No functional change intended.

Nit: It is a little bit misleading to write "Use ... FIELD_PREP()"
since this patch actually never uses FIELD_PREP().

Reviewed-by: Niklas Cassel <cassel@...nel.org>