linux-kernel - Re: [PATCH] PCI: dwc: ep: Use FIELD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a9092968-9d19-4d5e-89bb-1063a3d8d93b@163.com>
Date: Thu, 24 Apr 2025 22:39:17 +0800
From: Hans Zhang <18255117159@....com>
To: Niklas Cassel <cassel@...nel.org>
Cc: lpieralisi@...nel.org, bhelgaas@...gle.com, jingoohan1@...il.com,
 manivannan.sadhasivam@...aro.org, kw@...ux.com, robh@...nel.org,
 thomas.richard@...tlin.com, linux-pci@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCI: dwc: ep: Use FIELD_GET()



On 2025/4/24 21:44, Niklas Cassel wrote:
> On Mon, Apr 21, 2025 at 07:45:48PM +0800, Hans Zhang wrote:
>> Use FIELD_GET() and FIELD_PREP() to remove dependences on the field
>> position, i.e., the shift value. No functional change intended.
> 
> Nit: It is a little bit misleading to write "Use ... FIELD_PREP()"
> since this patch actually never uses FIELD_PREP().
> 
> Reviewed-by: Niklas Cassel <cassel@...nel.org>

Hi Niklas,

Thank you very much for your review. I think Mani can help me modify it 
when merging to the temporary branch.

Best regards,
Hans