linux-kernel - Re: [PATCH v4 2/5] dt-bindings: pci: cadence: Extend compatible for new EP configurations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250424-elm-magma-b791798477ab@spud>
Date: Thu, 24 Apr 2025 16:29:35 +0100
From: Conor Dooley <conor@...nel.org>
To: hans.zhang@...tech.com
Cc: bhelgaas@...gle.com, lpieralisi@...nel.org, kw@...ux.com,
	manivannan.sadhasivam@...aro.org, robh@...nel.org,
	krzk+dt@...nel.org, conor+dt@...nel.org, peter.chen@...tech.com,
	linux-pci@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Manikandan K Pillai <mpillai@...ence.com>
Subject: Re: [PATCH v4 2/5] dt-bindings: pci: cadence: Extend compatible for
 new EP configurations

On Thu, Apr 24, 2025 at 09:04:41AM +0800, hans.zhang@...tech.com wrote:
> From: Manikandan K Pillai <mpillai@...ence.com>
> 
> Document the compatible property for HPA (High Performance Architecture)
> PCIe controller EP configuration.

Please explain what makes the new architecture sufficiently different
from the existing one such that a fallback compatible does not work.

Same applies to the other binding patch.

Thanks,
Conor.

> 
> Signed-off-by: Manikandan K Pillai <mpillai@...ence.com>
> Signed-off-by: Hans Zhang <hans.zhang@...tech.com>
> ---
>  .../devicetree/bindings/pci/cdns,cdns-pcie-ep.yaml          | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.yaml b/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.yaml
> index 98651ab22103..a7e404e4f690 100644
> --- a/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.yaml
> +++ b/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.yaml
> @@ -7,14 +7,16 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
>  title: Cadence PCIe EP Controller
>  
>  maintainers:
> -  - Tom Joseph <tjoseph@...ence.com>
> +  - Manikandan K Pillai <mpillai@...ence.com>
>  
>  allOf:
>    - $ref: cdns-pcie-ep.yaml#
>  
>  properties:
>    compatible:
> -    const: cdns,cdns-pcie-ep
> +    enum:
> +      - cdns,cdns-pcie-ep
> +      - cdns,cdns-pcie-hpa-ep
>  
>    reg:
>      maxItems: 2
> -- 
> 2.47.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)