linux-kernel - Re: [RFC PATCH net-next] net: stmmac: sun8i: drop unneeded default syscon value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4974609.GXAFRqVoOG@jernej-laptop>
Date: Thu, 24 Apr 2025 20:39:44 +0200
From: Jernej Škrabec <jernej.skrabec@...il.com>
To: Andrew Lunn <andrew+netdev@...n.ch>,
 "David S . Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Andre Przywara <andre.przywara@....com>
Cc: Chen-Yu Tsai <wens@...e.org>, Samuel Holland <samuel@...lland.org>,
 Corentin Labbe <clabbe.montjoie@...il.com>, Yixun Lan <dlan@...too.org>,
 Maxime Ripard <mripard@...nel.org>, netdev@...r.kernel.org,
 linux-sunxi@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject:
 Re: [RFC PATCH net-next] net: stmmac: sun8i: drop unneeded default syscon
 value

Dne sreda, 23. april 2025 ob 11:52:22 Srednjeevropski poletni čas je Andre Przywara napisal(a):
> For some odd reason we are very picky about the value of the EMAC clock
> register from the syscon block, insisting on a certain reset value and
> only doing read-modify-write operations on that register, even though we
> pretty much know the register layout.
> This already led to a basically redundant variant entry for the H6, which
> only differs by that value. We will have the same situation with the new
> A523 SoC, which again is compatible to the A64, but has a different syscon
> reset value.
> 
> Drop any assumptions about that value, and set or clear the bits that we
> want to program, from scratch (starting with a value of 0). For the
> remove() implementation, we just turn on the POWERDOWN bit, and deselect
> the internal PHY, which mimics the existing code.
> 
> Signed-off-by: Andre Przywara <andre.przywara@....com>

Thanks for doing that!

Reviewed-by: Jernej Skrabec <jernej.skrabec@...il.com>

Best regards,
Jernej