linux-kernel - Re: [PATCH v2] wifi: mt76: mt7996: Fix null-ptr-deref in mt7996_mmio_wed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEnQdOrroDzrz+Y4ch8EGTP6T798-zwLpMJi5eNaW_S+Ew+BtQ@mail.gmail.com>
Date: Thu, 24 Apr 2025 11:23:39 +0800
From: henry martin <bsdhenrymartin@...il.com>
To: nbd@....name, lorenzo@...nel.org, ryder.lee@...iatek.com, 
	shayne.chen@...iatek.com, sean.wang@...iatek.com, matthias.bgg@...il.com, 
	angelogioacchino.delregno@...labora.com, chui-hao.chiu@...iatek.com, 
	bsdhenrymartin@...il.com, rex.lu@...iatek.com
Cc: linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH v2] wifi: mt76: mt7996: Fix null-ptr-deref in mt7996_mmio_wed_init()

Hi all,

I’d like to kindly follow up on my previous patch submission to check if there
are any additional feedback or suggestions for improvement. If there are
further changes needed, I’ll be happy to address them and send a v3.

Please let me know if you have any comments. Thanks for your time and review!

Best regards,

Henry Martin <bsdhenrymartin@...il.com> 于2025年4月7日周一 11:24写道：
>
> devm_ioremap() returns NULL on error. Currently, mt7996_mmio_wed_init()
> does not check for this case, which results in a NULL pointer
> dereference.
>
> Prevent null pointer dereference in mt7996_mmio_wed_init()
>
> Fixes: 83eafc9251d6 ("wifi: mt76: mt7996: add wed tx support")
> Signed-off-by: Henry Martin <bsdhenrymartin@...il.com>
> ---
> V1 -> V2: Add a blank after the check and correct the summary.
>
>  drivers/net/wireless/mediatek/mt76/mt7996/mmio.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7996/mmio.c b/drivers/net/wireless/mediatek/mt76/mt7996/mmio.c
> index 13b188e281bd..af9169030bad 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7996/mmio.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7996/mmio.c
> @@ -323,6 +323,9 @@ int mt7996_mmio_wed_init(struct mt7996_dev *dev, void *pdev_ptr,
>         wed->wlan.base = devm_ioremap(dev->mt76.dev,
>                                       pci_resource_start(pci_dev, 0),
>                                       pci_resource_len(pci_dev, 0));
> +       if (!wed->wlan.base)
> +               return -ENOMEM;
> +
>         wed->wlan.phy_base = pci_resource_start(pci_dev, 0);
>
>         if (hif2) {
> --
> 2.34.1
>