linux-kernel - Re: [PATCH] pci: j721e: fix host/endpoint dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <573c92aa-f891-47c9-9ea8-c71e89694a11@ti.com>
Date: Thu, 24 Apr 2025 10:49:08 +0530
From: Siddharth Vadapalli <s-vadapalli@...com>
To: Arnd Bergmann <arnd@...nel.org>
CC: Lorenzo Pieralisi <lpieralisi@...nel.org>,
        Krzysztof
 Wilczyński <kw@...ux.com>,
        Manivannan Sadhasivam
	<manivannan.sadhasivam@...aro.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Vignesh Raghavendra <vigneshr@...com>, Arnd Bergmann <arnd@...db.de>,
        Rob
 Herring <robh@...nel.org>,
        Siddharth Vadapalli <s-vadapalli@...com>,
        Kishon
 Vijay Abraham I <kishon@...nel.org>,
        Thomas Richard
	<thomas.richard@...tlin.com>,
        Théo Lebrun
	<theo.lebrun@...tlin.com>,
        Sergio Paracuellos <sergio.paracuellos@...il.com>,
        <linux-pci@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-omap@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] pci: j721e: fix host/endpoint dependencies

On Wed, Apr 23, 2025 at 06:25:16PM +0200, Arnd Bergmann wrote:

Hello Arnd,

Thank you for the Fix.

> From: Arnd Bergmann <arnd@...db.de>
> 
> The j721e driver has a single platform driver that can be built-in or
> a loadable module, but it calls two separate backend drivers depending
> on whether it is a host or endpoint.
> 
> If the two modes are not the same, we can end up with a situation where
> the built-in pci-j721e driver tries to call the modular host or endpoint
> driver, which causes a link failure:
> 
> ld.lld-21: error: undefined symbol: cdns_pcie_ep_setup
> >>> referenced by pci-j721e.c
> >>>               drivers/pci/controller/cadence/pci-j721e.o:(j721e_pcie_probe) in archive vmlinux.a
> 
> ld.lld-21: error: undefined symbol: cdns_pcie_host_setup
> >>> referenced by pci-j721e.c
> >>>               drivers/pci/controller/cadence/pci-j721e.o:(j721e_pcie_probe) in archive vmlinux.a
> 
> Rework the dependencies so that the 'select' is done by the common
> Kconfig symbol, based on which of the two are enabled. Effectively
> this means that having one built-in makes the other either built-in
> or disabled, but all configurations will now build.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Reviewed-by: Siddharth Vadapalli <s-vadapalli@...com>

Regards,
Siddharth.