linux-kernel - Re: [PATCH v2] Input: cyttsp5 - fix power control issue on wakeup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <ed682022-509e-452b-b4f8-7ddeb17a2475@app.fastmail.com>
Date: Thu, 24 Apr 2025 18:00:02 +1000
From: Alistair <alistair@...stair23.me>
To: "Hugo Villeneuve" <hugo@...ovil.com>,
 "Linus Walleij" <linus.walleij@...aro.org>,
 "Dmitry Torokhov" <dmitry.torokhov@...il.com>,
 "Maximilian Weigand" <mweigand@...igand.net>
Cc: "Mikael Gonella-Bolduc" <mgonellabolduc@...onoff.com>,
 stable@...r.kernel.org, "Hugo Villeneuve" <hvilleneuve@...onoff.com>,
 linux-input@...r.kernel.org,
 "Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] Input: cyttsp5 - fix power control issue on wakeup

On Wed, 23 Apr 2025, at 11:52 PM, Hugo Villeneuve wrote:
> From: Mikael Gonella-Bolduc <mgonellabolduc@...onoff.com>
> 
> The power control function ignores the "on" argument when setting the
> report ID, and thus is always sending HID_POWER_SLEEP. This causes a
> problem when trying to wakeup.
> 
> Fix by sending the state variable, which contains the proper HID_POWER_ON or
> HID_POWER_SLEEP based on the "on" argument.
> 
> Fixes: 3c98b8dbdced ("Input: cyttsp5 - implement proper sleep and wakeup procedures")
> Cc: stable@...r.kernel.org
> Signed-off-by: Hugo Villeneuve <hvilleneuve@...onoff.com>
> Signed-off-by: Mikael Gonella-Bolduc <mgonellabolduc@...onoff.com>

Reviewed-by: Alistair Francis <alistair@...stair23.me>

Alistair

> ---
> Changes for v2:
> - Add Mikael SOB tag
> 
> drivers/input/touchscreen/cyttsp5.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/touchscreen/cyttsp5.c b/drivers/input/touchscreen/cyttsp5.c
> index eafe5a9b89648..86edcacb4ab3e 100644
> --- a/drivers/input/touchscreen/cyttsp5.c
> +++ b/drivers/input/touchscreen/cyttsp5.c
> @@ -580,7 +580,7 @@ static int cyttsp5_power_control(struct cyttsp5 *ts, bool on)
> int rc;
>  
> SET_CMD_REPORT_TYPE(cmd[0], 0);
> - SET_CMD_REPORT_ID(cmd[0], HID_POWER_SLEEP);
> + SET_CMD_REPORT_ID(cmd[0], state);
> SET_CMD_OPCODE(cmd[1], HID_CMD_SET_POWER);
>  
> rc = cyttsp5_write(ts, HID_COMMAND_REG, cmd, sizeof(cmd));
> 
> base-commit: 7adf8b1afc14832de099f9e178f08f91dc0dd6d0
> -- 
> 2.39.5
> 
>