linux-kernel - Re: [PATCH v2] Input: cyttsp5 - fix power control issue on wakeup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4yohupeiamzt7sw3qvuj427xsulpk7jcwyixtljhmbih3mzos3@nwyuv6hbxvzz>
Date: Mon, 28 Apr 2025 12:19:14 -0700
From: Dmitry Torokhov <dmitry.torokhov@...il.com>
To: Hugo Villeneuve <hugo@...ovil.com>
Cc: Linus Walleij <linus.walleij@...aro.org>, 
	Maximilian Weigand <mweigand@...igand.net>, Alistair Francis <alistair@...stair23.me>, 
	Mikael Gonella-Bolduc <mgonellabolduc@...onoff.com>, stable@...r.kernel.org, 
	Hugo Villeneuve <hvilleneuve@...onoff.com>, linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] Input: cyttsp5 - fix power control issue on wakeup

On Wed, Apr 23, 2025 at 09:52:43AM -0400, Hugo Villeneuve wrote:
> From: Mikael Gonella-Bolduc <mgonellabolduc@...onoff.com>
> 
> The power control function ignores the "on" argument when setting the
> report ID, and thus is always sending HID_POWER_SLEEP. This causes a
> problem when trying to wakeup.
> 
> Fix by sending the state variable, which contains the proper HID_POWER_ON or
> HID_POWER_SLEEP based on the "on" argument.
> 
> Fixes: 3c98b8dbdced ("Input: cyttsp5 - implement proper sleep and wakeup procedures")
> Cc: stable@...r.kernel.org
> Signed-off-by: Hugo Villeneuve <hvilleneuve@...onoff.com>
> Signed-off-by: Mikael Gonella-Bolduc <mgonellabolduc@...onoff.com>

Applied, thank you.

-- 
Dmitry