linux-kernel - Re: [PATCH] x86/sgx: Use SHA-256 library API instead of crypto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ae48d190-03fd-4f4d-ab6f-969301e8b96e@intel.com>
Date: Mon, 28 Apr 2025 12:19:50 -0700
From: Dave Hansen <dave.hansen@...el.com>
To: Eric Biggers <ebiggers@...nel.org>, x86@...nel.org,
 linux-sgx@...r.kernel.org, Jarkko Sakkinen <jarkko@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org
Subject: Re: [PATCH] x86/sgx: Use SHA-256 library API instead of crypto_shash
 API

On 4/28/25 11:38, Eric Biggers wrote:
> -static int sgx_get_key_hash(const void *modulus, void *hash)
> -{
> -	struct crypto_shash *tfm;
> -	int ret;
> -
> -	tfm = crypto_alloc_shash("sha256", 0, CRYPTO_ALG_ASYNC);
> -	if (IS_ERR(tfm))
> -		return PTR_ERR(tfm);
> -
> -	ret = __sgx_get_key_hash(tfm, modulus, hash);
> -
> -	crypto_free_shash(tfm);
> -	return ret;
> -}

Let's just say, theoretically, that there was some future hardware that
also supported SHA384.  There doesn't seem to be a SHA-384 library API.

Would you leave the crypto_shash() in place if that were to be
happening? Theoretically of course.