linux-kernel - Re: [PATCH] printk/panic: deduplicate backtrace on PANIC_PRINT_ALL_CPU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aAoDC76UiSpCJhGY@pathway.suse.cz>
Date: Thu, 24 Apr 2025 11:23:23 +0200
From: Petr Mladek <pmladek@...e.com>
To: Kevin Mitchell <kevmitch@...sta.com>
Cc: "Guilherme G . Piccoli" <gpiccoli@...lia.com>,
	Jani Nikula <jani.nikula@...el.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	John Ogness <john.ogness@...utronix.de>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Ryo Takakura <takakura@...inux.co.jp>,
	Joel Granados <joel.granados@...nel.org>,
	Jocelyn Falempe <jfalempe@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] printk/panic: deduplicate backtrace on
 PANIC_PRINT_ALL_CPU_BT

On Wed 2025-04-23 13:26:17, Kevin Mitchell wrote:
> On panic, the backtrace of the panicking CPU will be printed either from
> within panic() itself or by the oops handling. Previously, when
> PANIC_PRINT_ALL_CPU_BT was enabled, the backtrace of the panicking CPU
> would be printed again.
> 
> To avoid cluttering up the crash log or console with this redundant
> information, this commit omits the panicking CPU from the all-cpu
> backtrace printed by panic_printk=PANIC_PRINT_ALL_CPU_BT.
> 
> Signed-off-by: Kevin Mitchell <kevmitch@...sta.com>

Makes sense. The patch looks good to me.

Reviewed-by: Petr Mladek <pmladek@...e.com>

Best Regards,
Petr