linux-kernel - Re: [PATCH] printk/panic: deduplicate backtrace on PANIC_PRINT_ALL_CPU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <342e81f3-cd5c-0220-8327-3904f2ebf401@igalia.com>
Date: Thu, 1 May 2025 18:51:19 -0300
From: "Guilherme G. Piccoli" <gpiccoli@...lia.com>
To: Kevin Mitchell <kevmitch@...sta.com>
Cc: Petr Mladek <pmladek@...e.com>, Jani Nikula <jani.nikula@...el.com>,
 Andrew Morton <akpm@...ux-foundation.org>,
 John Ogness <john.ogness@...utronix.de>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Ryo Takakura <takakura@...inux.co.jp>,
 Joel Granados <joel.granados@...nel.org>,
 Jocelyn Falempe <jfalempe@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] printk/panic: deduplicate backtrace on
 PANIC_PRINT_ALL_CPU_BT

On 23/04/2025 17:26, Kevin Mitchell wrote:
> On panic, the backtrace of the panicking CPU will be printed either from
> within panic() itself or by the oops handling. Previously, when
> PANIC_PRINT_ALL_CPU_BT was enabled, the backtrace of the panicking CPU
> would be printed again.
> 
> To avoid cluttering up the crash log or console with this redundant
> information, this commit omits the panicking CPU from the all-cpu
> backtrace printed by panic_printk=PANIC_PRINT_ALL_CPU_BT.
> 
> Signed-off-by: Kevin Mitchell <kevmitch@...sta.com>
> ---
>  kernel/panic.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Makes total sense - thanks for the improvement!
Feel free to add my:

Reviewed-by: Guilherme G. Piccoli <gpiccoli@...lia.com>

Cheers!