linux-kernel - Re: [PATCH 5/7] soundwire: sysfs: Use ATTRIBUTE_GROUP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <680995e25de06_71fe294b0@dwillia2-xfh.jf.intel.com.notmuch>
Date: Wed, 23 Apr 2025 18:37:38 -0700
From: Dan Williams <dan.j.williams@...el.com>
To: "David E. Box" <david.e.box@...ux.intel.com>, <corbet@....net>,
	<bhelgaas@...gle.com>, <kuurtb@...il.com>, <hdegoede@...hat.com>,
	<ilpo.jarvinen@...ux.intel.com>, <vkoul@...nel.org>,
	<yung-chuan.liao@...ux.intel.com>, <pierre-louis.bossart@...ux.dev>,
	<sanyog.r.kale@...el.com>, <gregkh@...uxfoundation.org>, <rafael@...nel.org>,
	<dakr@...nel.org>, <dan.j.williams@...el.com>,
	<andriy.shevchenko@...ux.intel.com>
CC: <linux-doc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-pci@...r.kernel.org>, <platform-driver-x86@...r.kernel.org>,
	<Dell.Client.Kernel@...l.com>, <linux-sound@...r.kernel.org>
Subject: Re: [PATCH 5/7] soundwire: sysfs: Use ATTRIBUTE_GROUP_VISIBLE()

David E. Box wrote:
> Replace the manual definition of the dp0 attribute group with the newly
> introduced ATTRIBUTE_GROUP_VISIBLE() macro, simplifying the code and
> improving maintainability.
> 
> Consolidate the definition of dp0_attrs and move the attribute array above
> the macro so that they are visibly tied together.  While here, also remove
> the unneeded trailing comma after NULL at the end of all attribute arrays.

I am generally not a fan of "while we're at it" clauses, but this looks
ok.

Reviewed-by: Dan Williams <dan.j.williams@...el.com>