linux-kernel - Re: [PATCH] nvmet-tcp: don't restore null sk_state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <w2nqgyguk5kcpci3j6eaiiy6cztriy3t5iddlqf3kggehudkhw@cpbm2ochdd46>
Date: Thu, 24 Apr 2025 01:38:48 +0000
From: Shinichiro Kawasaki <shinichiro.kawasaki@....com>
To: Alistair Francis <alistair23@...il.com>
CC: hch <hch@....de>, "sagi@...mberg.me" <sagi@...mberg.me>, "kch@...dia.com"
	<kch@...dia.com>, "linux-nvme@...ts.infradead.org"
	<linux-nvme@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "csander@...estorage.com"
	<csander@...estorage.com>, "hare@...e.de" <hare@...e.de>, Alistair Francis
	<Alistair.Francis@....com>
Subject: Re: [PATCH] nvmet-tcp: don't restore null sk_state_change

On Apr 23, 2025 / 16:06, Alistair Francis wrote:
> queue->state_change is set as part of nvmet_tcp_set_queue_sock(), but if
> the TCP connection isn't established when nvmet_tcp_set_queue_sock() is
> called then queue->state_change isn't set and sock->sk->sk_state_change
> isn't replaced.
> 
> As such we don't need to restore sock->sk->sk_state_change if
> queue->state_change is NULL.
...
> 
> Resolves: https://lore.kernel.org/linux-nvme/5hdonndzoqa265oq3bj6iarwtfk5dewxxjtbjvn5uqnwclpwt6@a2n6w3taxxex/
> Signed-off-by: Alistair Francis <alistair.francis@....com>

Thanks for the fix. I applied this patch to the kernel v6.15-rc3 and confirmed
it avoids the hang at blktests test case nvme/062. I also ran whole blktests and
observed no regression.

Tested-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@....com>