linux-kernel - Re: [PATCH v2 1/1] iommu: Allow attaching static domains in iommu_attach_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d9756d68-9d40-4fa7-8d11-5a260dc4f4cd@linux.intel.com>
Date: Thu, 24 Apr 2025 09:36:19 +0800
From: Baolu Lu <baolu.lu@...ux.intel.com>
To: Jason Gunthorpe <jgg@...dia.com>
Cc: Joerg Roedel <joro@...tes.org>, Will Deacon <will@...nel.org>,
 Robin Murphy <robin.murphy@....com>, Kevin Tian <kevin.tian@...el.com>,
 shangsong2@...ovo.com, Dave Jiang <dave.jiang@...el.com>,
 iommu@...ts.linux.dev, linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH v2 1/1] iommu: Allow attaching static domains in
 iommu_attach_device_pasid()

On 4/23/25 22:21, Jason Gunthorpe wrote:
> On Wed, Apr 23, 2025 at 10:18:39AM +0800, Lu Baolu wrote:
>> @@ -3435,7 +3448,8 @@ int iommu_attach_device_pasid(struct iommu_domain *domain,
>>   	    !ops->blocked_domain->ops->set_dev_pasid)
>>   		return -EOPNOTSUPP;
>>   
>> -	if (ops != domain->owner || pasid == IOMMU_NO_PASID)
>> +	if (!domain_iommu_ops_compatible(ops, domain) ||
>> +	    pasid == IOMMU_NO_PASID)
>>   		return -EINVAL;
> Convert all the places checking domain->owner to the new function..
> 
> static int __iommu_attach_group(struct iommu_domain *domain,
> 				struct iommu_group *group)
> 
> int iommu_replace_device_pasid(struct iommu_domain *domain,
> 			       struct device *dev, ioasid_t pasid,
> 			       struct iommu_attach_handle *handle)

Sure. Will make it in a new version.

Thanks,
baolu